Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp416918pxv; Thu, 22 Jul 2021 03:31:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvHYgPvuum6qTnEjWCntJtiNh9MRfGnotU2JdeGGvulrjPi83ZbE2unMldP3KXwT5G1Sfy X-Received: by 2002:a05:6638:1646:: with SMTP id a6mr17355468jat.1.1626949873982; Thu, 22 Jul 2021 03:31:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626949873; cv=none; d=google.com; s=arc-20160816; b=kW0fFw29JkpOJDTh/wV70iZAlH0FKLQLWL0VDYnANDmDpIkK6oMEDBoSJqDjDiFmht xRI+0U2yRuAGu/iKpPD+MIYcV9N3jcfhdzc0t5DLnVAo6OFVY1cnCsBJicceEB08QCvm R0ut0I6WIzbxPiniksssAD014Uu4ZHajwx4ReD9AY89SJ0LCMZhTkZ/GgNNoT8litz/X epScQSgn9WQ3P9dc6DOXjy6tovlEfOFpSuqHIVq60KeXqk0j3dqIfbB/7tIOF2lgM0Nb vz9snk971/EVSD8RQxEnNaWWy0rzyAF5JJNAhEYkdW4bSw1lKgBECVQBSCWv/yLkn8TZ 2YUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=mOODDQzjCZTeO1Lb3PyXLdX3U76F5Y5HHgnRXizcZvY=; b=fCHLHx+X6gsYcjXnq4Vj6iNGAlyJ3xLJFsGPh837ybM6fmX/EqnNnqMowLsXOZB0VP bp14EvtT+HfkuBNYc2YECZIqKu5pRhHP6uxdkV0FzC+jwxhj+l1G4nAhb0dWyoCBBabz vL5dmTpgyHZ+pkItwsm2wMqOqUaCc4TjDwdIJm5+l+IMzyEA73h3KZetMMnUPxUa+dex F+H2TO6RgDx9TcshjNQmBdPDRFCwb8gVgbiR9Dyq8oOM5D+CFmUd1KCd592P5wdrDDDF sI7y5jcVBogabNMZ6idS41m1ylPSoNfx59QQPcx0ORgApFbryjK8ertwFF46UZJuATO0 2VeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ehlhd1I8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x9si28662553jat.100.2021.07.22.03.31.03; Thu, 22 Jul 2021 03:31:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ehlhd1I8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231621AbhGVJsT (ORCPT + 99 others); Thu, 22 Jul 2021 05:48:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:58230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231609AbhGVJsS (ORCPT ); Thu, 22 Jul 2021 05:48:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 092F06128A; Thu, 22 Jul 2021 10:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626949734; bh=dKkz0H90g75Jqm7Tv0Fj0nBgj32L9xL5yzrVGuWSxd0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Ehlhd1I88u+UOpYo4uuAqDJZmujkb/zzPVO68lh4VsKsGbAS0GQ4bffDY+AG8w1FN uINgg9X0Rsdhl2h4+yj5HePRqRoB264TqfSaruZmiSobSFjJGp4yKJDNlq3p/QAKn5 S4jscchMtclnJUaMy1PTWXVl8S3bsnHLdoeE5jLZLiCBMc44WNJOfxYJvLo+Gg4OQd g+3jlWjNayJINWCR10so/xuaYvomJM2mSIdsawcrv64x8LC91MYl1ohNrNvcCZBWUS lMcRBX8wZRdPfVe/caUtmAqM93EvkNz63XlJ3f+QPibA5XWwcTAx7s3jufOwqxkKa+ pMd9MR3d8cmjQ== Received: by mail-wr1-f52.google.com with SMTP id l7so5358077wrv.7; Thu, 22 Jul 2021 03:28:53 -0700 (PDT) X-Gm-Message-State: AOAM53153SNi2JjWR+VIKnFtQdkm/AyknUsh8Ne/rsSMWuVUpaBscb9d Eek1s9igm2GwtNg60+UhQXiu9b9kayry1P5TrRo= X-Received: by 2002:a5d:65cb:: with SMTP id e11mr49542874wrw.105.1626949732596; Thu, 22 Jul 2021 03:28:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Thu, 22 Jul 2021 12:28:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 1/5] dt-bindings: virtio: Add binding for virtio devices To: Viresh Kumar Cc: Jason Wang , "Michael S. Tsirkin" , Rob Herring , Jean-Philippe Brucker , Vincent Guittot , Bill Mills , =?UTF-8?B?QWxleCBCZW5uw6ll?= , "Enrico Weigelt, metux IT consult" , Jie Deng , DTML , Linux Kernel Mailing List , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 11:57 AM Viresh Kumar wrote: > > Allow virtio device sub-nodes to be added to the virtio mmio or pci > nodes. The compatible property for virtio device must be of format > "virtio,", where DID is virtio device ID in hexadecimal format. > > Signed-off-by: Viresh Kumar Looks good to me overall. One question would be for the exact format of the 'compatible' string. After seeing this version, I would slightly prefer "virtio,device22" over "virtio,22". I think in the previous version we had mentioned both, but not actually decided on which one to use. Arnd