Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 22 Jul 2021 14:16:55 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Dongliang Mu <mudongliangabcd@gmail.com>
Cc:     Vinod Koul <vkoul@kernel.org>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soundwire: stream: add s_rt into slave_rt_list before
 sdw_config_stream
Message-ID: <20210722111654.GW25548@kadam>
References: <20210722105611.1582803-1-mudongliangabcd@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210722105611.1582803-1-mudongliangabcd@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JN2P275CA0024.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:3::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.25 via Frontend Transport; Thu, 22 Jul 2021 11:17:09 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 85015885-d6cc-4a27-57a9-08d94d02426f
X-MS-TrafficTypeDiagnostic: MWHPR1001MB2253:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR1001MB2253C6D605D4524076B13FD58EE49@MWHPR1001MB2253.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: aDSudFiV0IY9o8bCVzRneXDIsSc6TdGVtc112pmmvJJ27wW0ITucbwXwPLdC4Dxee/kLvEt6UELtZDHVNsy+v+v0aKd9VTuMAa+e/DecXS4DDRylh91/CvfVRJ6Lyj6zTkSs/9G7jn32m3WKWbugRKyLbuiAf74yB5RiKAU0e7Oeq2o8jrip5nXzfixOLS3Kgce+DJjARDJ322nhceciOv+hmRUmr7KXNVnRBpzBaYbTYSexZRnKkgQ9d91VFw9w89O7NcghLsI67nYHoJxVxaFq3v3sJSCXvMyNhpclb+X7nGJTWYztXjpJqaN/iXKIrzbylTzvFJ5Hw1Q5UZDL/ZSlgcgg9+yn5hpi3Xt8iV0D9CRNaVjcSBYUR+7Ns10jMyoQN0FcZwVdjCPaHay+WwKYpogXuMM1h3UoMggwUYXSNN9/MWDYT4ZSakvG6T79HNx/uyW6ogTBFdu5mHBFShw4jGzSgW5KfG5rqVZtFXvYzF6Lo2/UQRW/VdE9pKOD3Oz/lEoURrXXooKwxGv+yEbz3r2zHDbA7tQBF08RegcXT+E8dZ3HyzjlZ+Bm/3a2Y8EW9+feFeEPJqo9oZBK8qeTGjOGp/MO844uFRLIhcDnP0JLF7cRCEg8pZcOhLtZfHHoh2zLcDVPLOgGT19zJnQ9RweVcKIz+vWkAjN4BzHCcArWHLdqORgZde7m0Fpn9Yn4T2hsOywRC79n3xY+JQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(136003)(366004)(376002)(39860400002)(9576002)(956004)(8676002)(33656002)(8936002)(55016002)(1076003)(2906002)(6666004)(66476007)(66556008)(83380400001)(33716001)(44832011)(38350700002)(478600001)(66946007)(9686003)(316002)(4326008)(6916009)(6496006)(5660300002)(86362001)(52116002)(186003)(38100700002)(26005)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cdZLWucnmkafJieHggRivaghnLA1L3DN74/bR/TT8+g/I1bSx+Tc67SZ1Qho?=
 =?us-ascii?Q?cqTkwZV9QLJ/mH+UIjMFVluKXvXYpRu0vTEEsOoFbZPyIShK5AYsZJS6Aq5q?=
 =?us-ascii?Q?ZgLFvU71Stp4+MOLdY8mtqw2uDAKaZkWVCjh02t2FHfygrw+zgfR11HvgcWh?=
 =?us-ascii?Q?JJBclVAeY8WGON+Zv++J6lcBzdE/OX6/vxbg0U0JJqx7NgEKJqfdizMMOxKk?=
 =?us-ascii?Q?UKAfXlBWH8DqC7bp5JAbxV1fkQ7VssURHrK5w59lms6tlOGUTqtEgMER/XIo?=
 =?us-ascii?Q?fRC0DS+HgdXT15j5qaalzhztmAqp4ccoUEBiS6wrDoyBiUxsghcx4AF++ioj?=
 =?us-ascii?Q?Z4QdN28qHzXZQgeX461+jQ0QUmru/tR1u/OdR7bW1Lp5cGlDv5Wy3VmMDK8h?=
 =?us-ascii?Q?gaEFAOas1isPONqg6/avBhP5DN4fsO99QTGNSDe2SdvmJQ4tjFb0ToHrxAB3?=
 =?us-ascii?Q?VH4Piw6cl3ebCkUD0Wh5WzapEg4aj4eh1xDMFac+CQtozBz7AKdTJgeci6pR?=
 =?us-ascii?Q?KP15tf29Ch4mnwa1JJdDeseWqCxK2xDkffbqnMkun9eYR1QTqSOusVAz3c2A?=
 =?us-ascii?Q?e6euJ0XsNxLTwAUCkqx90K3eg//oBXB3HyM2NJRvkVgb47WBc50W68/m2GbY?=
 =?us-ascii?Q?NlSbrZKPCSnaIbMS9HCO/WoSnYztlSgqsM1vJmjLYfombaJhPBDoYdJLUHay?=
 =?us-ascii?Q?HtHAnylM7Ph4C8ADgZUOalwF4N9w217phJSuLLWX1c96UI933XdRQBr+J30r?=
 =?us-ascii?Q?wPfbkyJVEf4gOfLDVJ7TecbACSKP1QMPZK+hiLvaLKE9SbhI7YA73i30Eyp2?=
 =?us-ascii?Q?CPM1IoLH0xGgcxF0KAAwDsCxsZciWoZemyv+tcygGcxj22ldz8pU5SKjsEI+?=
 =?us-ascii?Q?rcqMvwaFuafq/Rkn3icskiB6749bHzrO5A6LKr9EmkoM94m9MxFmUYOLUhzs?=
 =?us-ascii?Q?FliVSE9hqXt7z4VvYevVkZ6bb3Xc4E53K+ma8/VFeFVcVOQpqHBD+15+IXNG?=
 =?us-ascii?Q?m75hEVpnTdpdeFzCkKskC6JxCLaeGEdZfwBuk6+jK3pwbkrIKTw6m+IbtqB1?=
 =?us-ascii?Q?ocmkyBjW4IQ0hBd2rnxI+EMh8E3S7y7fqW6HbcIGEW1iln3w8ZKcl86ll7sB?=
 =?us-ascii?Q?p8hbp+wuHozPf4plkmlbnPkA3zMUqpi9ZYSt6qODp+TscgmyoTySgl0EFDN1?=
 =?us-ascii?Q?WCfbhuxt3UCPljrj6TL+Xkj21N1Y+PzsHqs1StOUJi66RxS5uPusI2ACVBhx?=
 =?us-ascii?Q?yG5jQPvBmGxl5vqpZ6rN7fhF1upQAXd+wjwecK1Ms1AwlfIeTM/s917ilbvX?=
 =?us-ascii?Q?GUvu2GNdGpAZpsp5ts/e1Skt?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85015885-d6cc-4a27-57a9-08d94d02426f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2021 11:17:15.4669
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uik3v/yGXL6FO3Jw13gRFXr1d4ZBpDuqJhf3fTuA47KCL/Im2S10Z6EMBa8l4vXmmsxPwz8xXVi5ul6g5qM5Cej0hq3px/20N9liTPFSnII=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2253
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10052 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0
 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107220074
X-Proofpoint-ORIG-GUID: 9rrS4eAiDtBn9q5-0MApTpPFNeAsumPh
X-Proofpoint-GUID: 9rrS4eAiDtBn9q5-0MApTpPFNeAsumPh
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 22, 2021 at 06:56:11PM +0800, Dongliang Mu wrote:
> The commit 48f17f96a817 ("soundwire: stream: fix memory leak in stream
> config error path") fixes the memory leak by implicitly freeing the s_rt
> object. However, this fixing style is not very good.
> 
> The better fix is to move list_add_tail before sdw_config_stream and
> revert the previous commit.
> 
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
>  drivers/soundwire/stream.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
> index 1a18308f4ef4..66a4ce4f923f 100644
> --- a/drivers/soundwire/stream.c
> +++ b/drivers/soundwire/stream.c
> @@ -1373,19 +1373,11 @@ int sdw_stream_add_slave(struct sdw_slave *slave,
>  		goto stream_error;
>  	}
>  
> +	list_add_tail(&s_rt->m_rt_node, &m_rt->slave_rt_list);
> +
>  	ret = sdw_config_stream(&slave->dev, stream, stream_config, true);

There some sanity checks on the stream inside sdw_config_stream() so
that's probably why we didn't add it until later.  (I don't know the
code well, but that's what I would suspect from a glance).

regards,
dan carpenter