Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp517915pxv; Thu, 22 Jul 2021 06:02:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzL+VG/70kXbAtvmy0DB1GORq1gEFbRPtLLFzizFTAoBJTr+G6+kMQEgRiUVoqowyouI2E5 X-Received: by 2002:a05:6e02:2188:: with SMTP id j8mr27816518ila.14.1626958952653; Thu, 22 Jul 2021 06:02:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626958952; cv=none; d=google.com; s=arc-20160816; b=1Bf/pImkg8Q6EyHYujF66WipqD1Rd++X/t+tvsOCYjG2+Kssds4YtL12R0ltf4MNWO oZfvdp6Cfo2yosJ7f+b0mX9NCBNVb0q7RIWwV4x8tyn8n+33WSn3yeU0CUYQ81Hi0P/s cec2SuXuSxwOP9iCf0jcWflgYRZ8OR1QD2NBCIQXZEN87AarRrocWo4ScneasKr/mJKu W30ZenygY11kK4niuZ54tbcZoebqxa5+PUtgw7E8tEQ6ulE9/YFluDad/WwbrvIBTet2 VPskC7ldzuYBybwTcl0GNtNEb1OYYqXp4ukTYka6LFojQzogn/QTfH+gkAKiBR2G9+bu 8Bvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ZjrSboXq8Wh6PAVtpJlL7Bl65TSwVlCpkDCM7G7dupw=; b=h6AaoKVMP0MOnhVoZ3w8gQyKbtg3NoUaUaaPD4vBxGG3hBOcUldGoo2rgaZrE7pICx mL5AwOt5NDEXk5oyQVcYCvagUURYZvaHeOpLLYsudFszzIaww6wGZnjjYJy84RTGJNb6 RVAT4kwWmEWeByes5/mVZWa+ffdkfo13OB17lgoBhdApPtTQAbcsK1/sf5bRumjKmuU9 JfIYcDGBWvp+1+ZMReAruNO1QGFZbAWAcHY9c5xMB2io/5no1THyAlXjIMPhcO4yxLep owZNnauYAtE49q7q4FNJBoIe00y8i6evKimb1KgjQGHhDkEA4EbsxtUGbC6ELzDy2eMv e2bA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o7si18373158jao.123.2021.07.22.06.02.21; Thu, 22 Jul 2021 06:02:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231965AbhGVMUP (ORCPT + 99 others); Thu, 22 Jul 2021 08:20:15 -0400 Received: from verein.lst.de ([213.95.11.211]:34056 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231938AbhGVMUK (ORCPT ); Thu, 22 Jul 2021 08:20:10 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id BCEFF68BEB; Thu, 22 Jul 2021 15:00:42 +0200 (CEST) Date: Thu, 22 Jul 2021 15:00:42 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: linux-arch@vger.kernel.org, Arnd Bergmann , "James E.J. Bottomley" , Al Viro , Anton Ivanov , Brian Cain , Chris Zankel , Christian Borntraeger , Christoph Hellwig , Guo Ren , Heiko Carstens , Helge Deller , Jeff Dike , Linus Walleij , Max Filippov , Michal Simek , Richard Weinberger , Thomas Bogendoerfer , Vasily Gorbik , Vineet Gupta , Yoshinori Sato , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, uclinux-h8-devel@lists.sourceforge.jp Subject: Re: [PATCH v3 4/9] arc: use generic strncpy/strnlen from_user Message-ID: <20210722130042.GD26225@lst.de> References: <20210722124814.778059-1-arnd@kernel.org> <20210722124814.778059-5-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722124814.778059-5-arnd@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 02:48:09PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Remove the arc implemenation of strncpy/strnlen and instead use the > generic versions. The arc version is fairly slow because it always does > byte accesses even for aligned data, and its checks for user_addr_max() > differ from the generic code. > > Signed-off-by: Arnd Bergmann Looks good, Reviewed-by: Christoph Hellwig