Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp538591pxv; Thu, 22 Jul 2021 06:28:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzFXtDV4Cf+bseG/fTCuN4GAEzhfgHMPNxWqRrr1Sr3Wf1fpejXGniGwi28MMCvPp0Ucl+ X-Received: by 2002:a02:cebb:: with SMTP id z27mr35894907jaq.72.1626960501505; Thu, 22 Jul 2021 06:28:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626960501; cv=none; d=google.com; s=arc-20160816; b=ux+r/XOxvSvdb0jHB3E0HUXbhzT5pg/90v6dfDmE2+eN1Mky7jAffAjSatzDBy7q38 2qojtnSrVQ4i2jvc4jsqG7OYMYDAhUPwPBwgXmkKqAcRGaNjim3I7InHJboMS/x0Pe74 z/EJcfVhA/7l07j0MFjacvTUPvTe7mENCWbIkUBeed0qFXPs7LRc6vwNKbV705+/t0oS IdNUBW+qc1NwxdbIAy4klhAHiIB5CYmA21w+qkWXYDJZVHXtD8fAjAJo2UeLFX733Boy NAd2/+GkXAxDPKzB8JsL5l3XQGvFBdG/YqyI4jaoNVHFh9dQRB3mba10EMfuoqJRK8rj uw8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bXi3VE0eK7e4hZudTVmsUw9yB2D3LHlNR0sxGpuQxsQ=; b=V1gyfYEMSDcE/dAJi8/XWz842qh2RKGz8bUw0gpQuP6t9oRUgf9VOQuu7UucaStNW7 lrdvAXuc8ApdPRkCIWbrTBssUXY5R415ruNSIVRovZpz0tle/wdjOHjMryYm3iAvRtkQ lDfbX1J03s7I4F1cLwhTL2eJRaFP0Y4KdRH89nrbgl+uKB4fTNMr7al5YahDHjFi4Qu4 4ViZlz6Qxu3KkzkuGHoDulKNMceogq4eEuhe1xD3v6AkT2WYi8HM6A7Kqr1k+koSEW/f 0Hxco5RDdGRPUfk1/feFfIpwD6C8ohBhUneT2dp80JM/GXmCf3glxY7rC+BhUPyyMzI9 kHoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mOzAXRtq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b20si21086709jat.16.2021.07.22.06.28.09; Thu, 22 Jul 2021 06:28:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mOzAXRtq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232097AbhGVMqV (ORCPT + 99 others); Thu, 22 Jul 2021 08:46:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:42084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231938AbhGVMqU (ORCPT ); Thu, 22 Jul 2021 08:46:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 709F360FEE; Thu, 22 Jul 2021 13:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626960415; bh=+uL4L29wsoeIrn9I4PopKZ7ciOxU0fozSHm7hEtJRaA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mOzAXRtqcugR4cbq3OZ5I8AKQ8QQhGkkyOozUUY9xBQ0I5NEwtkdgEsSwZCJsdN/+ 3bjvn18Caqjm7YHAFh8jWTESB+wOgqiuj5PRefDbB42xcQurO6032HAthHLzg3O2Hd 5NQaMgvg+iMGAQSuZ7xMqrR8uynVN49YlEvWISUc= Date: Thu, 22 Jul 2021 15:26:52 +0200 From: Greg KH To: Matthew Wilcox Cc: Zhouyi Zhou , Chris Clayton , Oleksandr Natalenko , Miaohe Lin , Boqun Feng , paulmck@kernel.org, linux-kernel , stable@vger.kernel.org, Chris Rankin , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , rcu , Andrew Morton , Linux-MM , "Huang, Ying" Subject: Re: linux-5.13.2: warning from kernel/rcu/tree_plugin.h:359 Message-ID: References: <5812280.fcLxn8YiTP@natalenko.name> <2237123.PRLUojbHBq@natalenko.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 01:36:02PM +0100, Matthew Wilcox wrote: > On Thu, Jul 22, 2021 at 04:57:57PM +0800, Zhouyi Zhou wrote: > > Thanks for reviewing, > > > > What I have deduced from the dmesg is: > > In function do_swap_page, > > after invoking > > 3385 si = get_swap_device(entry); /* rcu_read_lock */ > > and before > > 3561 out: > > 3562 if (si) > > 3563 put_swap_device(si); > > The thread got scheduled out in > > 3454 locked = lock_page_or_retry(page, vma->vm_mm, vmf->flags); > > > > I am only familiar with Linux RCU subsystem, hope mm people can solve our > > confusions. > > I don't understamd why you're still talking. The problem is understood. > You need to revert the unnecessary backport of 2799e77529c2 and > 2efa33fc7f6e Sorry for the delay, will go do so in a minute... greg k-h