Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp561203pxv; Thu, 22 Jul 2021 07:02:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQPOakOSOlmcrKJmjqFJpoarQLrWRk3Tfuz5PCsBESxIpQRl5++YzZ2lbBDYzhkyWf8QNZ X-Received: by 2002:aa7:d809:: with SMTP id v9mr55320129edq.146.1626962558555; Thu, 22 Jul 2021 07:02:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626962558; cv=none; d=google.com; s=arc-20160816; b=k+p8N2lR6q09RE9rraCCfSUO5DFPdIrpNL69vpmGHfHiEbFf/qRvcOolj1D4hvhwZO vKTtAvAoert9F60bd6jRx3vE/NxUpasNU5nz5n5F6vJ1/thjiN4wbpAAJHaEiZwkZvnn qX5xqiWshKn3RN51DIs3F7slKJKvLSHEdvxvfqKbjcBIsPTgwC7Z1JqzQhLVIgVNYsVf u85tKYiKTbu/UM/KFkEUagXZLqlpaAE7KBxLcUrlLaC4Mq49vhRjtXhxR/ZD2yR+LcKT g+QIXYsmd20GdfVcjdMQJdpZCKY702mnXwF+SKZw1rxNgyWVrrssXHFeeNIBx7jY0mRs 36rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jaa61b04f7o7l3ZC/81vooq9+5AO+I4lzfFHxocVqMA=; b=ly62vQVBEOXVccfgHIDyUW3jYgt8KkC++ZQIZUphlOGcl5GKggPo5rpYsJeqFNOU/4 OObBGZG8/5ZU//Efc3iy63lRsgiTI2zUpQ7XOArQcfDdgtgHeL1CiY1Q3PjdWzayLNn0 YBG6oHVMTY3h1hL71goW0/xsWthYKNMT+LpaiUxtYoEP4p7lCMGmAeC171B4/cmIq0eX mNs+rZKJR64xLITIrnSLbkS7yAfxcCUSYy7zVdkp++R8S8zoojEXHtIT5byDKkX1zUik VhZIXZL6k8f9rNiiLkTQGLxKNpd7zBhdarcGdAGw8Hhxa9bgFyUllitpdEIYLsEXCmtR RO5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BU9bztdB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j5si11913394ejm.413.2021.07.22.07.02.13; Thu, 22 Jul 2021 07:02:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BU9bztdB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232202AbhGVNTw (ORCPT + 99 others); Thu, 22 Jul 2021 09:19:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:36474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232105AbhGVNTw (ORCPT ); Thu, 22 Jul 2021 09:19:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0BE6661244; Thu, 22 Jul 2021 14:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626962426; bh=vYStKlL0lfpbehwAhl3t7pf+aiD3WIfX+cNEvQkFKEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BU9bztdBMi5Ej7JJmuiMsLpZJlyrnjWZ6zNuH77O+G/Fz0hVvxfQiPT8ddS+bEnjE Ad9P3IjoLHTovV15f412VlMK5ozt/bjbe3EZGqB+aauu3E3EgW3FJXiZB8PzSToctp cw5jr6AEqTH5dFXzEs3knNNtNVuvd87hAIfYCOJU= Date: Thu, 22 Jul 2021 16:00:24 +0200 From: Greg KH To: Matthew Wilcox Cc: Zhouyi Zhou , Chris Clayton , Oleksandr Natalenko , Miaohe Lin , Boqun Feng , paulmck@kernel.org, linux-kernel , stable@vger.kernel.org, Chris Rankin , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , rcu , Andrew Morton , Linux-MM , "Huang, Ying" Subject: Re: linux-5.13.2: warning from kernel/rcu/tree_plugin.h:359 Message-ID: References: <5812280.fcLxn8YiTP@natalenko.name> <2237123.PRLUojbHBq@natalenko.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 03:26:52PM +0200, Greg KH wrote: > On Thu, Jul 22, 2021 at 01:36:02PM +0100, Matthew Wilcox wrote: > > On Thu, Jul 22, 2021 at 04:57:57PM +0800, Zhouyi Zhou wrote: > > > Thanks for reviewing, > > > > > > What I have deduced from the dmesg is: > > > In function do_swap_page, > > > after invoking > > > 3385 si = get_swap_device(entry); /* rcu_read_lock */ > > > and before > > > 3561 out: > > > 3562 if (si) > > > 3563 put_swap_device(si); > > > The thread got scheduled out in > > > 3454 locked = lock_page_or_retry(page, vma->vm_mm, vmf->flags); > > > > > > I am only familiar with Linux RCU subsystem, hope mm people can solve our > > > confusions. > > > > I don't understamd why you're still talking. The problem is understood. > > You need to revert the unnecessary backport of 2799e77529c2 and > > 2efa33fc7f6e > > Sorry for the delay, will go do so in a minute... Both now reverted from 5.10.y and 5.13.y. thanks, greg k-h