Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210719182001.1573-1-alexander.helms.jy@renesas.com>
 <20210719182001.1573-2-alexander.helms.jy@renesas.com> <20210719224804.GA2768983@robh.at.kernel.org>
 <6fbb307e-8835-224e-7912-2b956985a713@renesas.com>
In-Reply-To: <6fbb307e-8835-224e-7912-2b956985a713@renesas.com>
From:   Rob Herring <robh@kernel.org>
Date:   Thu, 22 Jul 2021 08:19:47 -0600
Message-ID: <CAL_Jsq+2tpjNffzNPDa2XSZWAk3B-HS-bF7EmZ_j0t_=nfEWvg@mail.gmail.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: Add binding for Renesas 8T49N241
To:     Alex Helms <alexander.helms.jy@renesas.com>
Cc:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Michael Turquette <mturquette@baylibre.com>,
        "open list:MEDIA DRIVERS FOR RENESAS - FCP" 
        <linux-renesas-soc@vger.kernel.org>, david.cater.jc@renesas.com,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        linux-clk <linux-clk@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 20, 2021 at 10:58 AM Alex Helms
<alexander.helms.jy@renesas.com> wrote:
>
> On 7/19/2021 3:48 PM, Rob Herring wrote:
> > On Mon, 19 Jul 2021 11:20:00 -0700, Alex Helms wrote:
> >> Renesas 8T49N241 has 4 outputs, 1 integral and 3 fractional dividers.
> >> The 8T49N241 accepts up to two differential or single-ended input clocks
> >> and a fundamental-mode crystal input. The internal PLL can lock to either
> >> of the input reference clocks or to the crystal to behave as a frequency
> >> synthesizer.
> >>
> >> Signed-off-by: Alex Helms <alexander.helms.jy@renesas.com>
> >> ---
> >>  .../bindings/clock/renesas,8t49n241.yaml      | 190 ++++++++++++++++++
> >>  MAINTAINERS                                   |   6 +
> >>  2 files changed, 196 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml
> >>
> >
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
> >
>
> Thank you for the info. I'm new to the kernel process and appreciate your advice.
>
> I felt uncomfortable adding your Reviewed-By tag but since there were no changes to the dt
> portion of the patch, in retrospect I guess I should have added it. I'll keep this in mind
> for the future. Is there anything I need to do for this patch?

For v5, no. If there's a v6 posted, then add any tags.

Rob