Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp670878pxv; Thu, 22 Jul 2021 09:23:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBtgi+eK3njX+vCoVq5A7gqkvM0S2h6s5ZeIV1alpWrd8ZgAPI9JKmMErpaRW4kAZvK48m X-Received: by 2002:a05:6e02:c8e:: with SMTP id b14mr441642ile.236.1626971012489; Thu, 22 Jul 2021 09:23:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626971012; cv=none; d=google.com; s=arc-20160816; b=PPujwlriXAn5ULd7qiNfp35fDFGJBx5ZO2CEAGcMCfE89YAokcwO0Te2ijk3Hx8w7R xQ3hT8+3CWdIvMbBV1ikRo3bdq4xAWiwtMtuMnCpmFd0avHgfSp3Xwm6nAVEPn3K2NwG NgkQj63r7720Vrq/aeaT79+yqJDuGTZHjRoZx5CO/pEdsXFE9q+t64VMEv5ViV/dSZGA zYc9/HpC/gLaifNJlspENHG7qcOkLbvadmVyexkeyiarJnNORhJysb/cUpLOOEhP4NYc TYHTt0AEn4x3LGNKNSCexpr+f73bUhFSHolPxDGkqbfHlPHEG7q4ktxOn7Q6W9icJAw4 twvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gFsVDeE3UrfGXCVray0L63x0Xu3EYm+JR9qAQuYh4I0=; b=SzKeB3aUn2fYkVH/PYcPxJAHJXum6YExX7Uv+Y0XP/HNVd+e+SNYXIWr1oAynNfoDF INaUXGKKWerEif3EkUvGqMR748yHwODZk6zV5L6gJwVgOhsdLU4lWxgFD/VR/Sb0d+Fc wpXVsd+tjK/IFuQxaWoYtIgDBfh5A1hM8KTQJxrZqC6YY+8F86zpjsGxzOl+0bb+Ubzb x0BUX5mVmLesO63dpgItUcGvxvm72PzvrHkwAnoun87wWXLkrQWYB7LHGjx4NFmEcPvH 0PGkPfgKO3bctJCqy11auusKH6eu15u8jISwDb7j7hfMSDuau4vnnpEtIszXQmjsAbA+ yUnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m8si21095752jav.78.2021.07.22.09.23.20; Thu, 22 Jul 2021 09:23:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229672AbhGVPl5 (ORCPT + 99 others); Thu, 22 Jul 2021 11:41:57 -0400 Received: from verein.lst.de ([213.95.11.211]:34894 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbhGVPl4 (ORCPT ); Thu, 22 Jul 2021 11:41:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B75EC67373; Thu, 22 Jul 2021 18:22:28 +0200 (CEST) Date: Thu, 22 Jul 2021 18:22:28 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: netdev@vger.kernel.org, Arnd Bergmann , Al Viro , Andrew Lunn , Christoph Hellwig , David Ahern , "David S. Miller" , Eric Dumazet , Hideaki YOSHIFUJI , Jakub Kicinski , Kees Cook , Marco Elver , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH net-next v6 1/6] compat: make linux/compat.h available everywhere Message-ID: <20210722162228.GA9882@lst.de> References: <20210722142903.213084-1-arnd@kernel.org> <20210722142903.213084-2-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722142903.213084-2-arnd@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 04:28:58PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Parts of linux/compat.h are under an #ifdef, but we end up > using more of those over time, moving things around bit by > bit. > > To get it over with once and for all, make all of this file > uncondititonal now so it can be accessed everywhere. There > are only a few types left that are in asm/compat.h but not > yet in the asm-generic version, so add those in the process. > > This requires providing a few more types in asm-generic/compat.h > that were not already there. The only tricky one is > compat_sigset_t, which needs a little help on 32-bit architectures > and for x86. > > Signed-off-by: Arnd Bergmann Looks good, Reviewed-by: Christoph Hellwig