Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp681575pxv; Thu, 22 Jul 2021 09:37:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJF87CjphhBZ8tsQPWN5wVDyzbYr505KwZrV3rNNyqDtGWxj1b8CsablMpL2ptyMaqHNjP X-Received: by 2002:a02:ccec:: with SMTP id l12mr359704jaq.61.1626971867164; Thu, 22 Jul 2021 09:37:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626971867; cv=none; d=google.com; s=arc-20160816; b=MRIWFTjwZwog9MJOfH8flEtJtWdy4vAQfBi/iBogLG7Jjy5ed+HH1pzkpql8rp6c+v DQmdziqDeaM4+qMxA16BhvFIlq+q/0eOQg/UmSmNp9GZzfB3vl6R1GA8tfHL6uN7TE3B sBFnOEZsL/plDKiepI1shk7efx1zDSpcZUrm45sxFz5XA4Dtbhr1oNr3/I6fVku0EOjV XrHF0BNWrm+4q0/CfQIcTDpLT6kiDZ9aA3b3OdiyRTW+tAYREAxVNfyhp8AWM/4w46Hr aK1/kZI2xT1spb3y0PgxYbskw2oaxZjxFQzntBIIq64Qtja9k8ZZ3H7BQSqDbroo37If tD3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w8nqMnGE+ELrvjpGiMQunRpzyV/HJw+2j0EJiIW9OkM=; b=PrL9AUh679RV40AfuEm9N7jdiSuKzmGmrkHfAwc+sMGLSdVBLCYtNFBCmJeXA/VMMW dS5lFL6LjyPqHZcX4dk/4wnCHNluAcODVnhkB3o2Qlv7T0+w5wKeGLhCDNEeylIwN2xq xiJVvZ8VGaqQYBvY9gpnzwRb02cnTN42f/FKxUEpn2ZzAw79yQrbMr0yv0h30fIb9cu2 jhB0gTDwmdJ/UdR80OHtlZPZQn9wOSnDZSOwvUqxw260eFWR/Bi7uYg2KnTnwb/Mfop6 S4jCuUY8hW0UgSNQOLOk4WOvBG3jZqNcjjVPsSveW17xT+A/KHxoKiIqypFfrkSHmZnP a3iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hECnCBZ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n24si32433256jal.91.2021.07.22.09.37.35; Thu, 22 Jul 2021 09:37:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hECnCBZ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232626AbhGVPyv (ORCPT + 99 others); Thu, 22 Jul 2021 11:54:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:58464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229984AbhGVPyb (ORCPT ); Thu, 22 Jul 2021 11:54:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F26526135B; Thu, 22 Jul 2021 16:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626971705; bh=HUKhC0Z0A+WPSxdT6LAgFeO61IKhQx4Z+w6Fm2TciYo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hECnCBZ4uBfagrXRBWVzlxYyL2cOJkZo8uyY59wbBe4ihrSiXdfTQi2HHzHTAtpXo hE9LVKZaEyn7FY/MgZK1xA3X8ejPuYO/9Ux5Uv5NatAjHWoWfrXc+3TyV1VNWK9v/o guqUD7pbjVHXRhxQtkwCeoQRtP1K30I8dTzwFtnk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Javed Hasan , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 40/71] scsi: libfc: Fix array index out of bound exception Date: Thu, 22 Jul 2021 18:31:15 +0200 Message-Id: <20210722155619.201273904@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210722155617.865866034@linuxfoundation.org> References: <20210722155617.865866034@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Javed Hasan [ Upstream commit b27c4577557045f1ab3cdfeabfc7f3cd24aca1fe ] Fix array index out of bound exception in fc_rport_prli_resp(). Link: https://lore.kernel.org/r/20210615165939.24327-1-jhasan@marvell.com Signed-off-by: Javed Hasan Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/libfc/fc_rport.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index 64500417c22e..326bd609a3d1 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -1160,6 +1160,7 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp, resp_code = (pp->spp.spp_flags & FC_SPP_RESP_MASK); FC_RPORT_DBG(rdata, "PRLI spp_flags = 0x%x spp_type 0x%x\n", pp->spp.spp_flags, pp->spp.spp_type); + rdata->spp_type = pp->spp.spp_type; if (resp_code != FC_SPP_RESP_ACK) { if (resp_code == FC_SPP_RESP_CONF) @@ -1182,11 +1183,13 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp, /* * Call prli provider if we should act as a target */ - prov = fc_passive_prov[rdata->spp_type]; - if (prov) { - memset(&temp_spp, 0, sizeof(temp_spp)); - prov->prli(rdata, pp->prli.prli_spp_len, - &pp->spp, &temp_spp); + if (rdata->spp_type < FC_FC4_PROV_SIZE) { + prov = fc_passive_prov[rdata->spp_type]; + if (prov) { + memset(&temp_spp, 0, sizeof(temp_spp)); + prov->prli(rdata, pp->prli.prli_spp_len, + &pp->spp, &temp_spp); + } } /* * Check if the image pair could be established -- 2.30.2