Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp685068pxv; Thu, 22 Jul 2021 09:41:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeJ2AKla6sRuQKJV2LHLTSlo0HLQbcoQaREOKLvq4swKJq82FFPSOm+mb1o9TgiEBKnLVK X-Received: by 2002:a6b:fe19:: with SMTP id x25mr473175ioh.39.1626972105682; Thu, 22 Jul 2021 09:41:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626972105; cv=none; d=google.com; s=arc-20160816; b=Sa29y1gcs1f9wSEh+25CNWahZhXUqiXaPHjbrj1Auc97KWqo0A9uuebITE1xzY/esi xzJIil+w2JLMYg5Szv2KYpulFIipAWhby/F0h2mB7jwwVkf64mgxhv6hy3MUIS2ceSoT O9YfSVbkR7EwNaNLlSVcpIIlisI2KiSMRTbdXST2Z6UMr7tr+LHyv5Eb78k8P7C70pwb AQo7H0h9zqIGNqJ9xStJ/s2cTVsdg+TstFgtUXwLgRW1oJDGtGXFcW6RMqexNzSf/uog luprdRQhOsOHXAgloBdDgji1EDIG/9ogOQ988c5H1UCPZzo6TXfZlf93FgzVn9UM6uPK h1bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZOhoAaIszIivyL/Hih4Fl4TXrXJxd64yqDZExRb3kz8=; b=xunRlJ58oer6OS+c+2staWz3R5x7tPPzq1begit78vVUauZui73JYX6L5d/3yuB1FI 0nW4QBHPFynXHDaAaZFjAnGoCxQvQmcV0TlvlBdiBKctsxvXbLoyMgJhhrOycSkiZ8Wj Idk8SYsG8HdjEEWB/VKz2CLpJvO5oJe8VUgeqBSdYKJzXqaSfNJIwFElsrxJbm2HqIon 6fX+B7lvDTlIkYrqSVKG963f+b8PDmP2Sur8N8dACLyyKwPxtX9ZambiE3vjiDlxBG79 UfSfjKvtLlMWY2MvRo38Na80/vipk6P5QWKwxZCp340ZdTSo3c5+rhJ/a8lxiKuiqM8f earA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LmZfHGTb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i187si8694130iof.20.2021.07.22.09.41.33; Thu, 22 Jul 2021 09:41:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LmZfHGTb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232729AbhGVQAD (ORCPT + 99 others); Thu, 22 Jul 2021 12:00:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:34872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233085AbhGVP57 (ORCPT ); Thu, 22 Jul 2021 11:57:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AE386135C; Thu, 22 Jul 2021 16:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626971914; bh=6lmjyxY1yhsgh0tWS0E2pLA/Evvzkg5aGOdnzpe7vOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LmZfHGTbyGBVUYT7dBBivsiQC/f1cljPCLZdqI/A9zXcjFc7ylSF6Unl+PJ92No6O lugAcnNnewN67dLfXjgziYPNx76j899VbMNqPYeTfPLOKzpLUSWC5fCCmJMzzfouuf mFRqzo8BaCOfK51Um62HnK22Bee62r6Kr1tbvz1M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Javed Hasan , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.10 073/125] scsi: libfc: Fix array index out of bound exception Date: Thu, 22 Jul 2021 18:31:04 +0200 Message-Id: <20210722155627.112965379@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210722155624.672583740@linuxfoundation.org> References: <20210722155624.672583740@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Javed Hasan [ Upstream commit b27c4577557045f1ab3cdfeabfc7f3cd24aca1fe ] Fix array index out of bound exception in fc_rport_prli_resp(). Link: https://lore.kernel.org/r/20210615165939.24327-1-jhasan@marvell.com Signed-off-by: Javed Hasan Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/libfc/fc_rport.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index a60b228d13f1..f40edb0dab70 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -1162,6 +1162,7 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp, resp_code = (pp->spp.spp_flags & FC_SPP_RESP_MASK); FC_RPORT_DBG(rdata, "PRLI spp_flags = 0x%x spp_type 0x%x\n", pp->spp.spp_flags, pp->spp.spp_type); + rdata->spp_type = pp->spp.spp_type; if (resp_code != FC_SPP_RESP_ACK) { if (resp_code == FC_SPP_RESP_CONF) @@ -1184,11 +1185,13 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp, /* * Call prli provider if we should act as a target */ - prov = fc_passive_prov[rdata->spp_type]; - if (prov) { - memset(&temp_spp, 0, sizeof(temp_spp)); - prov->prli(rdata, pp->prli.prli_spp_len, - &pp->spp, &temp_spp); + if (rdata->spp_type < FC_FC4_PROV_SIZE) { + prov = fc_passive_prov[rdata->spp_type]; + if (prov) { + memset(&temp_spp, 0, sizeof(temp_spp)); + prov->prli(rdata, pp->prli.prli_spp_len, + &pp->spp, &temp_spp); + } } /* * Check if the image pair could be established -- 2.30.2