Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp693726pxv; Thu, 22 Jul 2021 09:52:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxv6MkRNmq6+QX7XzZQ1d8T7628TYbPCAAi2FEtHnUfEvk8rC2x4DP6d24ysz3wBw7OP4i X-Received: by 2002:a05:6402:34c:: with SMTP id r12mr665772edw.278.1626972737378; Thu, 22 Jul 2021 09:52:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626972737; cv=none; d=google.com; s=arc-20160816; b=yvHXKpwT+jTCgyqzlyRsMghKvyzdMHil6CizVsaxzvMkaj8K6eXowKJiD/oG+niqsK DQ8M/W7lPjUMuvi4FixXFlspgO0Z/KTM+D5kHBFkr8GIW7nhyPV0cuzESLj7FRzOhBVg GG4/3w8MgGcjQZ9IID7Khd7ctB2ET4KDi3utZsUlZICJhtlNfUI64gU43k65oEJrWaMT 22DUtrIHUUUmx4WsvBm1v6vt2LjkFWiHFpF44P8+ERb4LQbwOIvfrSUpRCRLITLFHOi7 7Kf9x02WodGw2YY4UmF1fshCRO1Niq7cbheBj1gFQxSu6Uay49fcLovIkxtCWF4NoSZw rtJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SpA/FjB2iMvq1yEFJTt3q30WzkbJ8XFaw7uewSHalAs=; b=SSGZJyyzcnL30iA9lo1Ncu8EvXZO9bnv2TERs6XZQWNr9zQ3i90Rk5InptVRtXsFH3 PJtjs04vy4IVO1TqusRpCUoCxUFzm9Q5+Ur5hMf3rxI1pNdm2xLPzp7nJ8k4vJMm+1Al irK1OyjFBShL39vOeKJDG2oalkM2npXLvpS+JemjjOeeFO2Wjs3/uIMR+R1FqDZdKUHF 4L2k2EVPZN/rjkzZ76mZFMx6SAOMqPD4MAXDYMOTy3NfDAWisUVL+cHT4mgVmyLs5tV9 sbKQF2SlBrC4KSBv74zrpRitsZyoQVcGfFpxTfleosW7KoQP2bIsHDOSP9cgEoQ829G1 E1dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="fofo/MVn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g14si30110784eds.289.2021.07.22.09.51.54; Thu, 22 Jul 2021 09:52:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="fofo/MVn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235480AbhGVQJX (ORCPT + 99 others); Thu, 22 Jul 2021 12:09:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:43670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234835AbhGVQFt (ORCPT ); Thu, 22 Jul 2021 12:05:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0D2C961D5B; Thu, 22 Jul 2021 16:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626972383; bh=7rP6QNdzEhQzfiBxNXVn23g6FHgrvvvxuCVYYNNE+9k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fofo/MVnHxNFPG70A3Lfln0IeDYE0gNiHByiVSeIqro9LDywD7Y6By0gSZR6A44Ry J0seNYKAXs0xXzoAWwtU9N69EM3fi2CEH99k4+mTkOA+yE/OgieZlaeHb5jgkwkGhj DHtLOSZgaK+ZOWWDjhhV0IaWhlaySDAETzFBod9k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Javed Hasan , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.13 093/156] scsi: libfc: Fix array index out of bound exception Date: Thu, 22 Jul 2021 18:31:08 +0200 Message-Id: <20210722155631.382497196@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210722155628.371356843@linuxfoundation.org> References: <20210722155628.371356843@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Javed Hasan [ Upstream commit b27c4577557045f1ab3cdfeabfc7f3cd24aca1fe ] Fix array index out of bound exception in fc_rport_prli_resp(). Link: https://lore.kernel.org/r/20210615165939.24327-1-jhasan@marvell.com Signed-off-by: Javed Hasan Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/libfc/fc_rport.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index cd0fb8ca2425..33da3c1085f0 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -1162,6 +1162,7 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp, resp_code = (pp->spp.spp_flags & FC_SPP_RESP_MASK); FC_RPORT_DBG(rdata, "PRLI spp_flags = 0x%x spp_type 0x%x\n", pp->spp.spp_flags, pp->spp.spp_type); + rdata->spp_type = pp->spp.spp_type; if (resp_code != FC_SPP_RESP_ACK) { if (resp_code == FC_SPP_RESP_CONF) @@ -1184,11 +1185,13 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp, /* * Call prli provider if we should act as a target */ - prov = fc_passive_prov[rdata->spp_type]; - if (prov) { - memset(&temp_spp, 0, sizeof(temp_spp)); - prov->prli(rdata, pp->prli.prli_spp_len, - &pp->spp, &temp_spp); + if (rdata->spp_type < FC_FC4_PROV_SIZE) { + prov = fc_passive_prov[rdata->spp_type]; + if (prov) { + memset(&temp_spp, 0, sizeof(temp_spp)); + prov->prli(rdata, pp->prli.prli_spp_len, + &pp->spp, &temp_spp); + } } /* * Check if the image pair could be established -- 2.30.2