Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp696663pxv; Thu, 22 Jul 2021 09:57:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRJSb+lT8Eh41m+wHmjIDZ6knx7D7gmapl2KvGXOxrIoGPyNYGtFztWILEQgLAfJeY+gul X-Received: by 2002:a17:906:aac8:: with SMTP id kt8mr828934ejb.246.1626973041471; Thu, 22 Jul 2021 09:57:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626973041; cv=none; d=google.com; s=arc-20160816; b=mhbQBckN3tJ3GD15P4DPUyOb+M/rk4D66keswqEmdRvz6rGQMGjbqIwy4C7S3M+hXW 2rBokkk4PZM/o7GwgCUi3HN4mBS71atU80QC/lIaFp0/5eD3I7B/oIV03IZBnpDgm854 aGmtwlQDMbdIgv3eu39+24Wb0ZnnhbajnwCU4t5hJqstJk1kxY39reCRqhDH04/Mb76E 38PZ/+Y/Db8yHKgy6hi+pQ9lLSB3HMEnPZ+/4cvLlaXPQaRdozTootNm1n0+1YKcnJAd iTe3t9Ned1LuwAK4cE8FyEAesrdEu1srhVY24pc6GBTK04g2U324UK+3Xi1v54QDEPuo DHgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RpotrUATcBstMeygPNXvIGqTs9rXpJ+8zfnjo7CXCMA=; b=tZSfkPaGdIcKWuV22GGlgSV6ny+Q0OwlLFLrhVgY8yX4wPEGFywzh2W/i66y7/dZE+ jGDGvfZKIBwMUnjn5le/oVhmgUgkA4ND9miKlXc62kxRvlNKqXAruP7+w8HBTRBEcxZS a3N2PKPnf5kc8nGz6EDjrWt1wHoZgIgvY6BtaHW9aM7uOMApy2f2KQuSLy1T34i7v1+w dNxWGfjve6aqIQGjXQFcUHKsyt+lkDQbRJV89z3qtCiDK7RyLmQW4S9ghaTbfLFBe9dn F963+JCcoa0oK8LPTRWmQKiuGM4tf7UPLxm9DcuyorcbrP9VMKaa4pwSlAZYLttgOjN2 pDZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2vHCNWlk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q18si8087281edi.63.2021.07.22.09.56.57; Thu, 22 Jul 2021 09:57:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2vHCNWlk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbhGVQNY (ORCPT + 99 others); Thu, 22 Jul 2021 12:13:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:51588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235585AbhGVQJc (ORCPT ); Thu, 22 Jul 2021 12:09:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1C1186139A; Thu, 22 Jul 2021 16:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626972574; bh=tfFLnZJ5cbp46h2m1QVdO6q4hAjT1hWrCrz6ppi0hWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2vHCNWlkNj8PmyGHxQcs35jmcVNPFGqDjiRB3QlrdvaWrxnFG/tExY4MKTsOaIcwH FjVlVcGxaBSTcVbxjPVAEbGqsXdklXOEgOQtKDYfWrhKfbjATbl7EVseFbeT4SrFCt hR39e5E9zk4alGAyQnrwqBrH6oaHnpVjnZ/SF07U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aaron Ma , "David S. Miller" Subject: [PATCH 5.13 156/156] mt76: mt7921: continue to probe driver when fw already downloaded Date: Thu, 22 Jul 2021 18:32:11 +0200 Message-Id: <20210722155633.397039609@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210722155628.371356843@linuxfoundation.org> References: <20210722155628.371356843@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aaron Ma commit c34269041185dad1bab7a34f42ef9fab967a1684 upstream. When reboot system, no power cycles, firmware is already downloaded, return -EIO will break driver as error: mt7921e: probe of 0000:03:00.0 failed with error -5 Skip firmware download and continue to probe. Signed-off-by: Aaron Ma Fixes: 1c099ab44727c ("mt76: mt7921: add MCU support") Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c @@ -921,7 +921,7 @@ static int mt7921_load_firmware(struct m ret = mt76_get_field(dev, MT_CONN_ON_MISC, MT_TOP_MISC2_FW_N9_RDY); if (ret) { dev_dbg(dev->mt76.dev, "Firmware is already download\n"); - return -EIO; + goto fw_loaded; } ret = mt7921_load_patch(dev); @@ -939,6 +939,7 @@ static int mt7921_load_firmware(struct m return -EIO; } +fw_loaded: mt76_queue_tx_cleanup(dev, dev->mt76.q_mcu[MT_MCUQ_FWDL], false); #ifdef CONFIG_PM