Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp697574pxv; Thu, 22 Jul 2021 09:58:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsuZII131M78XmrVU9r0ZPJyL1AE8ZWHPskCm8PFbcVjdFJMytZ9z/Odp7xjQStIlxylVN X-Received: by 2002:a05:6e02:5cf:: with SMTP id l15mr533455ils.90.1626973131432; Thu, 22 Jul 2021 09:58:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626973131; cv=none; d=google.com; s=arc-20160816; b=mbbbHILKjHl8fXs6fbtbbqdiTwaqP0pELZEDXMoZXpNOlyGFSXHMrncX/N0RezHY1b VLdOLXeh/EUv0EdKvHWMU7W4oBI0Dwuj6ulK81t5cXdYOhCesVYRIljNrylfPSVjM1Ef yvN9+98qe2uD41CC/UeoSE2+Aq3R5Wq37B4VYp3bjOJJl2nIPWEWSA7MsBqlou173abX U1uFfUaQYM3Ooi4KKY48oeHTaqD9zQDHBnhOEiOjVP4bHdg1E08plmdrwIHEerga2O4b kDFwuUXr/uAcDfXAzklPy/72UQfvQvZ6S5uw0fby6tSH6B5NSjtgMZAmlUn0/bnLdUe5 cNsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=NSeXQeYmxa8PzyJHnQ3gvN2cMCMqz8LQtBZ9JUilE70=; b=tzERHORX5O1rXHeqhnh2CU2HPf9ZDc0wJpmvVJ9zR4JMqxDOxog0O/LEaEpH5OFLLx Xa9NkWc50T6nxWnhAMkciKTLr2HDG90ygUNfft7jvRYXpJqZKhKBDvUUD+Umdp5+SukS MxmKnYwTssxyl7oQIsS6z2HNCAirlBcJ95NAL5/EuaKm1DY6Uucg+gdBXU/0gJaWkEHb 4zoTY2LvnYRcPu9KtBvuJhBl8m7obDXcoXpzrQf/ZOWIrr8fik2VCNlNbEFkFhuF5NPp zU+CqOM4rqbB0DKBaJDlFcNFHoWvpTcbS+U+ekhJdoEO7e+gJneOuIf+K/oTerLRdqL4 6J5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g17si29055734jaq.116.2021.07.22.09.58.40; Thu, 22 Jul 2021 09:58:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230102AbhGVQQy (ORCPT + 99 others); Thu, 22 Jul 2021 12:16:54 -0400 Received: from verein.lst.de ([213.95.11.211]:35149 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231166AbhGVQNK (ORCPT ); Thu, 22 Jul 2021 12:13:10 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9F5F167373; Thu, 22 Jul 2021 18:53:42 +0200 (CEST) Date: Thu, 22 Jul 2021 18:53:42 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Gao Xiang , linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, LKML , Matthew Wilcox , Andreas Gruenbacher Subject: Re: [PATCH v6] iomap: support tail packing inline read Message-ID: <20210722165342.GA11435@lst.de> References: <20210722031729.51628-1-hsiangkao@linux.alibaba.com> <20210722053947.GA28594@lst.de> <20210722165109.GD8639@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722165109.GD8639@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 09:51:09AM -0700, Darrick J. Wong wrote: > The commit message is a little misleading -- this adds support for > inline data pages at nonzero (but page-aligned) file offsets, not file > offsets into the page itself. I suggest: It actually adds both. pos is the offset into the file.