Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp697634pxv; Thu, 22 Jul 2021 09:58:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlWqjYuZ2sIGQfEbSJl48B1nRBOnmYDUNtRtonQNRmSFywa2bVUFEHFxRs5OYsD6E3oPyZ X-Received: by 2002:a17:906:aac8:: with SMTP id kt8mr834071ejb.246.1626973137189; Thu, 22 Jul 2021 09:58:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626973137; cv=none; d=google.com; s=arc-20160816; b=SSkQv5NTi134JhYhC+C/5jldAxYQ8CVziGU9mYdedEcUlIllCrNDmrXdPEoSlrT1P+ +jblFWbFo6U/euhf2NGN0f1RUPbcI86SvFtAb6y3ERkG0FN4Zq8nzjI5iXX2TVK17OtG 7tOkYqnNMib6xQ3vl1RMS/tubV0jt4MiU7r0e/s4WUKK3Rsk+ZI4VX2iwbv/CUnFKRC9 UxfsXOBeoOSiKToSIkRdTVJuazwz8n89Y9Wm7Nv7LXCD0+Ddybc2m7N8Pvc9RHACCmWF 5H0YJiRUUK7QRmJ87BqLVy+o6Ip3/VJSe3Zp1czTxKpzZRBPwAFpTE8RKecUsxq/GqG3 ZfNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=364UsVDTYP0Phgr5v9WdIXFsh6yYbzmX5kmkiCgmhzA=; b=N30x1xH/UQbYozI4B7aLUBObrwFDgUy1E6hZoAckXI/5Jnaj7qMpFrL5vKfrkhF5Td bgqYSJhg6RpJJssaooa8aprffY7/0tHQbfC+oKp/90traD0EddXL0lPrX826YT6Cbflc HCgoj5FojOlhsAU88vpnvPTKmocKg56Eb6kwhRUZRiVRSRW3YaOnRuwsHQn3ANZZzFfh zA8UrY918yhhTmQA2ydGyz92nTnDA2Q+U3hZL07epprLupe6NKar8Em3yBTedotnjXzl 7LW0YnUYItuWfRvXaIbRi/QQAPDxg+IYScXcbjQGfhmvGApBfmKhQeZ9gM81PjOTGNs9 DuxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Pq0iWd4I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t24si7213836edr.590.2021.07.22.09.58.34; Thu, 22 Jul 2021 09:58:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Pq0iWd4I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234575AbhGVQNF (ORCPT + 99 others); Thu, 22 Jul 2021 12:13:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:44432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235497AbhGVQJY (ORCPT ); Thu, 22 Jul 2021 12:09:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C6E5361DC1; Thu, 22 Jul 2021 16:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626972563; bh=bxp28ytE6JLkgpD5YkX0/KOLSOb7QxiwSiht3C8xOdc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pq0iWd4IsugS3bqoAape06UGzK4GH9qKwXSNszq6K0/N4V0tLQvetnY9oTiOAEl1X 7lFNopGYGwBqBK6F3ufM39b9DBk9AjTi5hnw3GemWo4iwVX2HQ1Rtq17P1bAiMLh1Y +muvtRvldvob5E7nmyeeFuSIbre/IgPy1RHV+eUs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stephan Gerhold , newbyte@disroot.org, Linus Walleij Subject: [PATCH 5.13 152/156] drm/panel: nt35510: Do not fail if DSI read fails Date: Thu, 22 Jul 2021 18:32:07 +0200 Message-Id: <20210722155633.266506997@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210722155628.371356843@linuxfoundation.org> References: <20210722155628.371356843@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Walleij commit 1988e0d84161dabd99d1c27033fbd6ee439bf432 upstream. Failing to read the MTP over DSI should not bring down the system and make us bail out from using the display, it turns out that this happens when toggling the display off and on, and that write is often still working so the display output is just fine. Printing an error is enough. Tested by killing the Gnome session repeatedly on the Samsung Skomer. Fixes: 899f24ed8d3a ("drm/panel: Add driver for Novatek NT35510-based panels") Cc: Stephan Gerhold Reported-by: newbyte@disroot.org Acked-by: Stefan Hansson Signed-off-by: Linus Walleij Link: https://patchwork.freedesktop.org/patch/msgid/20210603231830.3200040-1-linus.walleij@linaro.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/gpu/drm/panel/panel-novatek-nt35510.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt35510.c @@ -706,9 +706,7 @@ static int nt35510_power_on(struct nt355 if (ret) return ret; - ret = nt35510_read_id(nt); - if (ret) - return ret; + nt35510_read_id(nt); /* Set up stuff in manufacturer control, page 1 */ ret = nt35510_send_long(nt, dsi, MCS_CMD_MAUCCTR,