Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <78784bd6436e7010914cde474d07e63ab073205c.camel@perches.com>
Subject: Re: [PATCH] checkpatch: add grammatical judgement for total output
From:   Joe Perches <joe@perches.com>
To:     Hu Haowen <src.res@email.cn>, apw@canonical.com
Cc:     dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
        linux-kernel@vger.kernel.org
Date:   Thu, 22 Jul 2021 10:01:01 -0700
In-Reply-To: <1e0a9acb-e973-7371-8425-05e066db0827@email.cn>
References: <20210721151416.30530-1-src.res@email.cn>
         <68b4f05607e9e44559e174d9b50e435fb58ef5aa.camel@perches.com>
         <1e0a9acb-e973-7371-8425-05e066db0827@email.cn>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2021-07-22 at 18:04 +0800, Hu Haowen wrote:
> On 2021/7/22 上午12:03, Joe Perches wrote:
> > On Wed, 2021-07-21 at 23:14 +0800, Hu Haowen wrote:
> > > There lacked a English grammatical identification within the final
> > > output of checkpatch.pl such as the following:
> > > 
> > >     total: 1 errors, 11 warnings, 4094 lines checked
> > >                   ^
> > > 
> > > Which violated the rule about the usage of the singular form and the
> > > plural form. Hence fix the issue up and make it output the proper
> > > sentence.
> > NAK
> > 
> > I appreciate the desire for precision but I don't want to require
> > any automated downstream user of checkpatch to be changed.
> > 
> > I think users understand the output even though it may not be
> > grammatically correct in some cases.
> 
> 
> How about another modification, which turns "errors" into "error(s)"?
> In this case not only did the meaning convey but automated users won't
> be confused toward their automatic programs.

I still think this doesn't need to be changed.