Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp709264pxv; Thu, 22 Jul 2021 10:14:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMtjzbP8F6If6VB+IUrFVFcUCXfcsA9+17mYJSJqekaBuEuaHATLDow/D2lnenI2ePn1BS X-Received: by 2002:a05:6402:34c:: with SMTP id r12mr792700edw.278.1626974085969; Thu, 22 Jul 2021 10:14:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626974085; cv=none; d=google.com; s=arc-20160816; b=gTy4FJw6xoxZQcPzDPp7mWGdFq2eiKsV+gx0PZi6/V6I1E/3p3+/EBOgTUjN1/Vs1B Sr3gJARg6srhRgMWA9LdyDxrDwWm2QCge6su5nATeXRVvQe1TQlFJCsPkF/iHV3AQ+xK xsK1n+4QMJpNA4TYrqrxruPtKFpfd5X3VUz8QrOzEOQMpjQsW7byBbRK3ifuZ8ELYRXf MA+U79qi/OUirKTJaEC4N/lDGzmVDuOiwNc4ao5jPYRr4AY7LeZRcLpMQOWQ3ELfymCW MGKjNrDZQA6NF4l/KoNaXwvfZfHJcBEPJbA5/Ks2VjAJZIsptw6xVv4PsUsRd0lwVBuU DfyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gAIiwe9cRPx+lC9yRJQx3nkOidciTuQL58u5/KPEh04=; b=IqaF5t25Ju2hAYPETvR/hk3abFO+MPCJrOo2iGpadB5NRn4iMS1zdrmox8xYiAJg1j gUhcHo20mQsgpSNWHu15/f7An0jfgcrQMPJrdg/qX/poOzsIPHROHdWg4QuvtBcgwaVS wPFEXowdSn+eit+VuvSS/lE3rO+p5r8VHt6f7OfHc0mdqjnWsrbqTW+RdKleCxBdFRja nor8nxAfkXXHHO3o2VAsFIPFerwAn4mKnAbCqhz1uUT3HKbhuFdGqNri1KVa8k974AIN eq4rWrQHIYtJyEOfL1/7s+fc7OnjOul82h+YTo8fl+SySUEdnLKFIZYvE0zQiDMw6jqK z26Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bFfHL+A8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y20si29948221edw.465.2021.07.22.10.14.21; Thu, 22 Jul 2021 10:14:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bFfHL+A8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233767AbhGVQ3s (ORCPT + 99 others); Thu, 22 Jul 2021 12:29:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:50784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233717AbhGVQ3o (ORCPT ); Thu, 22 Jul 2021 12:29:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1AADA61183; Thu, 22 Jul 2021 17:10:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626973819; bh=6tXsqxQclTT6KIHVXllKY41+MDNoERgynR2skjDE3sY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bFfHL+A8EXu7CYstSQ+1IjYoikwZaKgrPiwMvO91klckkR1wPj3SEexReAnIpYE7w SG5j7JiQ3veVXAqajXljEB0aT27fGq2Jw2t90a0aMwEHvYYL8WO4t7nNuzrr9R5Bec zqKqPCeL+0sj94ieU8iXm3iqK8G7rBqtxLc20Llp/C4KAF3mlg5dg8Ubyh8BjXvQ0w Pg7FBVyqjfQQzi1d0xjcL4Zvg2JEXTZn3BLwk1kBMxdYn+ynNrXnuMUFWB36IOxWHh FMvktb/YdWSeu2FNYkuXn4z35oz+m/c6F8qPSBtTstDvgS7fWZ6GD+C2H6yrNtjxgA X862uJ2jIDUPQ== From: Mark Brown To: Neil Armstrong , Jerome Brunet , Martin Blumenstingl , Kevin Hilman , Dongliang Mu Cc: Mark Brown , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH] spi: meson-spicc: fix memory leak in meson_spicc_remove Date: Thu, 22 Jul 2021 18:09:58 +0100 Message-Id: <162697114030.3066.15287754008678432008.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210720100116.1438974-1-mudongliangabcd@gmail.com> References: <20210720100116.1438974-1-mudongliangabcd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Jul 2021 18:01:16 +0800, Dongliang Mu wrote: > In meson_spicc_probe, the error handling code needs to clean up master > by calling spi_master_put, but the remove function does not have this > function call. This will lead to memory leak of spicc->master. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: meson-spicc: fix memory leak in meson_spicc_remove commit: 8311ee2164c5cd1b63a601ea366f540eae89f10e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark