Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210722140949.3knhduxozzaido2r@liuwe-devbox-debian-v2>
In-Reply-To: <20210722140949.3knhduxozzaido2r@liuwe-devbox-debian-v2>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu, 22 Jul 2021 10:25:46 -0700
Message-ID: <CAHk-=wirFvNqAvaNaABHc2mi7FKL4n6TEAwQ3WTyTJueJcHCvA@mail.gmail.com>
Subject: Re: [GIT PULL] Hyper-V fixes for 5.14-rc3
To:     Wei Liu <wei.liu@kernel.org>
Cc:     Linux Kernel List <linux-kernel@vger.kernel.org>,
        Linux on Hyper-V List <linux-hyperv@vger.kernel.org>,
        kys@microsoft.com, Stephen Hemminger <sthemmin@microsoft.com>,
        haiyangz@microsoft.com, decui@microsoft.com,
        Michael Kelley <mikelley@microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jul 22, 2021 at 7:09 AM Wei Liu <wei.liu@kernel.org> wrote:
>
>   - Reversion of a bogus patch that went into 5.14-rc1

When doing a revert, please explain it.

Yes, they are simple in the sense that they just undo something, but
at the same time, that "something" was done for a reason, and the
reason why that original change was wrong, and how it was noticed (ie
what the symptoms of the reverted patch were) is important.

I've pulled this, so it's too late now, but please please please
explain reverts in the future, not just a "This reverts commit XYZ".

                     Linus