Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2da3949fa3504592da42c9d01dc060691c6a8b8b.camel@redhat.com>
Subject: Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message
 failure
From:   Lyude Paul <lyude@redhat.com>
To:     khsieh@codeaurora.org, Jani Nikula <jani.nikula@linux.intel.com>
Cc:     robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org,
        abhinavk@codeaurora.org, aravindh@codeaurora.org,
        rsubbia@codeaurora.org, rnayak@codeaurora.org,
        freedreno@lists.freedesktop.org, airlied@linux.ie, daniel@ffwll.ch,
        maarten.lankhorst@linux.intel.com, mripard@kernel.org,
        tzimmermann@suse.de, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 22 Jul 2021 13:53:34 -0400
In-Reply-To: <a514c19f712a6feeddf854dc17cb8eb5@codeaurora.org>
References: <1625585434-9562-1-git-send-email-khsieh@codeaurora.org>
         <87zguy7c5a.fsf@intel.com>
         <a514c19f712a6feeddf854dc17cb8eb5@codeaurora.org>
Organization: Red Hat
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 2021-07-13 at 15:24 -0700, khsieh@codeaurora.org wrote:
> On 2021-07-07 01:37, Jani Nikula wrote:
> > On Tue, 06 Jul 2021, Kuogee Hsieh <khsieh@codeaurora.org> wrote:
> > > From: Rajkumar Subbiah <rsubbia@codeaurora.org>
> > > 
> > > Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
> > > selftests") added some debug code for sideband message tracing. But
> > > it seems to have unintentionally changed the behavior on sideband 
> > > message
> > > failure. It catches and returns failure only if DRM_UT_DP is enabled.
> > > Otherwise it ignores the error code and returns success. So on an MST
> > > unplug, the caller is unaware that the clear payload message failed 
> > > and
> > > ends up waiting for 4 seconds for the response. Fixes the issue by
> > > returning the proper error code.
> > > 
> > > Changes in V2:
> > > -- Revise commit text as review comment
> > > -- add Fixes text
> > > 
> > > Changes in V3:
> > > -- remove "unlikely" optimization
> > > 
> > > Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + 
> > > selftests")
> > > 
> > > Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org>
> > > Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
> > > 
> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > 
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> > 
> > 
> > > ---
> Lyude,
> Any comments from you?
> Thanks,

Hey! Sorry did I forget to respond to this?

Reviewed-by: Lyude Paul <lyude@redhat.com>

> 
> > >  drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++----
> > >  1 file changed, 6 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c 
> > > b/drivers/gpu/drm/drm_dp_mst_topology.c
> > > index 1590144..df91110 100644
> > > --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> > > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> > > @@ -2887,11 +2887,13 @@ static int process_single_tx_qlock(struct 
> > > drm_dp_mst_topology_mgr *mgr,
> > >         idx += tosend + 1;
> > > 
> > >         ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx);
> > > -       if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) {
> > > -               struct drm_printer p = drm_debug_printer(DBG_PREFIX);
> > > +       if (ret) {
> > > +               if (drm_debug_enabled(DRM_UT_DP)) {
> > > +                       struct drm_printer p =
> > > drm_debug_printer(DBG_PREFIX);
> > > 
> > > -               drm_printf(&p, "sideband msg failed to send\n");
> > > -               drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
> > > +                       drm_printf(&p, "sideband msg failed to send\n");
> > > +                       drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
> > > +               }
> > >                 return ret;
> > >         }
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat