Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 22 Jul 2021 17:53:58 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Wei Liu <wei.liu@kernel.org>,
        Linux Kernel List <linux-kernel@vger.kernel.org>,
        Linux on Hyper-V List <linux-hyperv@vger.kernel.org>,
        kys@microsoft.com, Stephen Hemminger <sthemmin@microsoft.com>,
        haiyangz@microsoft.com, decui@microsoft.com,
        Michael Kelley <mikelley@microsoft.com>
Subject: Re: [GIT PULL] Hyper-V fixes for 5.14-rc3
Message-ID: <20210722175358.lnvjdhnx7frtgznc@liuwe-devbox-debian-v2>
References: <20210722140949.3knhduxozzaido2r@liuwe-devbox-debian-v2>
 <CAHk-=wirFvNqAvaNaABHc2mi7FKL4n6TEAwQ3WTyTJueJcHCvA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHk-=wirFvNqAvaNaABHc2mi7FKL4n6TEAwQ3WTyTJueJcHCvA@mail.gmail.com>
Precedence: bulk

On Thu, Jul 22, 2021 at 10:25:46AM -0700, Linus Torvalds wrote:
> On Thu, Jul 22, 2021 at 7:09 AM Wei Liu <wei.liu@kernel.org> wrote:
> >
> >   - Reversion of a bogus patch that went into 5.14-rc1
> 
> When doing a revert, please explain it.
> 
> Yes, they are simple in the sense that they just undo something, but
> at the same time, that "something" was done for a reason, and the
> reason why that original change was wrong, and how it was noticed (ie
> what the symptoms of the reverted patch were) is important.
> 
> I've pulled this, so it's too late now, but please please please
> explain reverts in the future, not just a "This reverts commit XYZ".
> 

Sure. Noted.

Thanks,
Wei.