Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp789717pxv; Thu, 22 Jul 2021 12:11:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzt5y4w9B5g4PZfp9lvI5b4lLsrRCYEjfeNbwIxnb+acCltZnRUOtsf76OgRKQ3PDvIvFkL X-Received: by 2002:a50:b412:: with SMTP id b18mr1270610edh.103.1626981101479; Thu, 22 Jul 2021 12:11:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626981101; cv=none; d=google.com; s=arc-20160816; b=hFf1Eondf0VdXUzYkVoBfWLtKgQF8Tc6w4g1+HNXenklolnu825ScSRft/X7y+O50j 2Hzre3sbl1PYwPnGEP+GJqCrFGeFCWGyttwSEmoBUoXuWmWemFyMyQUFJ83v6lsFRRVd BiN89lR3KOrgBejWhBXzaI+/4i3S7L5HlgDP2cFz0GrlN7H+7W89P87C5/K8YiL3WJgr +7tzTBdd12FMSv7lU+dKhbtT56qvKgOQJJOxoDUOFpT6ZV6oQ7SjmWS0lYFb6RLoDQSg xRVQl/xWcduSrAKdTx1hQkJePBRbDDBiPLy5FsHgZE90nP7GDG6/0XaTn8jT+9rSP14w Cwog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=scp+1rc24jdnxfL7eF19kK3DL+3J9gDohwlrgvGebZ0=; b=B39EiE+QvE4kTtPOnnmui0cKj3pjLXMrxIEQXngRP9QV8ggvvWKlanj1eOVhRRDASU GhAZKF3cjXWwMIe+xD2sTA047DWm9mteFG2jiCgHQSf11x6IlYCUXXaEjjsnQ6bv1LF0 YWV5cuq1bk9VoM6+Hik1+e7ezsghxYWAMrHCGt4f6/DZzGC4GNk888rqY85U2SJTBYL2 hTCya4hkm1jEzH9JzSx8viED9KvYJzHh7ZLua+Aygfi+B/6I6ZZAHkJNG8hWV0i5QiJZ SadsVz7FOhAn+haluoOwJHraZiwWousWmU3giVDl+DPfKR/9+wi/U8kEsBPdNsOjby6Y k8EA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Kzg1+v+A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a5si30862541ejy.204.2021.07.22.12.11.17; Thu, 22 Jul 2021 12:11:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Kzg1+v+A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230345AbhGVS1c (ORCPT + 99 others); Thu, 22 Jul 2021 14:27:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230344AbhGVS13 (ORCPT ); Thu, 22 Jul 2021 14:27:29 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 923AEC061575 for ; Thu, 22 Jul 2021 12:08:04 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id s2-20020a0568301e02b02904ce2c1a843eso6253646otr.13 for ; Thu, 22 Jul 2021 12:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=scp+1rc24jdnxfL7eF19kK3DL+3J9gDohwlrgvGebZ0=; b=Kzg1+v+ASBz1l6YFdUYjoIJ1ycL30KyMVNUxiZbSsy/9xwgH7nYvbx0C2luXa/RK6v hHxo0L2IjE8alE4iJAA9A3eGelmKnpSy2X9ID5+zVi+2oucyhkHRSZFjbrdICtI1EGtp EERE2M2fk6+PWXVFGXH8veERzxrjmQZPsQdMI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=scp+1rc24jdnxfL7eF19kK3DL+3J9gDohwlrgvGebZ0=; b=exToPDitrzjB2pBXxwAuckRZuZkEYwEWhACyb62c+djO2889B51D+wGyRpmWYrlawO Se0bbE2HAR3u9wiCOl53L5zckpdcyPNUZcXCJDEpzYVxweH5Tact95LQKGm0qcZVQzf6 dDIxgTN3IGCoE1DmbQTYjV6tznOiBByOysI/SSaIBs1jX9q1hjaUN7CE6kDeFjoxL5Z1 C+RtaOEbOxQraN6Ngl3Eqv//OdWQQVfuOWhOQkm+aPst23IHvGa4XUkfb2we9St/aaKc zE4lw9JjgiZW+GTfSOas7UKEF70ytldUbVDXBCibQtLO67pw+GSry1yepVjCxHIhbw6O v88A== X-Gm-Message-State: AOAM530hmU4Sn82Mgy9i6hXT2z3IuAydwFSnXCIx7IajG2CZyrpAq+wz se3Mne9cWeQGzXneNHjbdjIsIdIVF1bzkEM/fS4Raw== X-Received: by 2002:a9d:650e:: with SMTP id i14mr838011otl.233.1626980883940; Thu, 22 Jul 2021 12:08:03 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 22 Jul 2021 19:08:03 +0000 MIME-Version: 1.0 In-Reply-To: <1626191647-13901-4-git-send-email-khsieh@codeaurora.org> References: <1626191647-13901-1-git-send-email-khsieh@codeaurora.org> <1626191647-13901-4-git-send-email-khsieh@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 22 Jul 2021 19:08:03 +0000 Message-ID: Subject: Re: [PATCH v2 3/7] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed. To: Kuogee Hsieh , dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run Cc: abhinavk@codeaurora.org, aravindh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Kuogee Hsieh (2021-07-13 08:54:03) > Aux hardware calibration sequence requires resetting the aux controller > in order for the new setting to take effect. However resetting the AUX > controller will also clear HPD interrupt status which may accidentally > cause pending unplug interrupt to get lost. Therefore reset aux > controller only when link is in connection state when dp_aux_cmd_fifo_tx() > fail. This fixes Link Layer CTS cases 4.2.1.1 and 4.2.1.2. > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd