Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] iommu/amd: Convert from atomic_t to refcount_t on
 pasid_state->count
To:     Xiyu Yang <xiyuyang19@fudan.edu.cn>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc:     yuanxzhang@fudan.edu.cn, Xin Tan <tanxin.ctf@gmail.com>
References: <1626683578-64214-1-git-send-email-xiyuyang19@fudan.edu.cn>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
Message-ID: <ec476aa0-dd6b-852c-439f-89735f5b08e7@amd.com>
Date:   Thu, 22 Jul 2021 14:34:53 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <1626683578-64214-1-git-send-email-xiyuyang19@fudan.edu.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.236.31.117] (165.204.77.1) by SN7P220CA0001.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.26 via Frontend Transport; Thu, 22 Jul 2021 19:34:55 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 89584513-c60d-4ca8-406f-08d94d47c8f5
X-MS-TrafficTypeDiagnostic: DM4PR12MB5198:
X-Microsoft-Antispam-PRVS: <DM4PR12MB519883947120A4A57066F2FBF3E49@DM4PR12MB5198.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:328;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +CXfDmmCX9Ua8RbzHohbFmIIhDPKcIEIaiOAGguBKru7GNVD1o9EYkzdHXq1DTAJ3/ygKPDORiIUfbL9LtcKYAwJrGVX84m25z0UmgRuLEeWIrhnfqaUAAerLimRbksFXxc71Wl/qnAXJ2+LU+ggai7Kkh63Fc/be5MJ1wT1+GcLseGAxxhuC35wtaDo0Nyu7A5unYg4zkd1fWTP4SqjEpfKdtzw1MI3eKzmyM2RIxGeriPIBjiO5lT0cw0JtAx/Q0H9P5LaMblgma3dX2dfSrnPyYUYDy0C85Gmv9rnztIwQOLO/lrlCVsERePVtl7ENOKo90d1UlhUowbLTPudfHiz5mDx530KhjR4TpFA4023pged3ix2GieuNncWQlbvUaJSTJ/B8e2HCwk3/lFKZ90rhaXpZHIenuKP6ZVN9Hw4EHWKIXWCx7s0j4TWjUvCRXeX8nqohseqOXjLIkCWVCazULyu+Wh/Qln/3vMqUv3CcUixNAFVZmtpjNDWqXf3Fsul8IBjuBNcZF+EvcLrvlixHb5OvlLRWgy5pe/BKpF3Ji68noPtyevbjhhJysAsXnqnUyoCDkCyTSePJ0lq49ufOmhXcb0B3c99RJhtTrll9V5iiuT9RSzpdch5Ax9Yh2WOjycp1jeD+3Ki8Hdt4wAyI8UpwU0CYoTWWKxsDWMZhikua+dzCV2hl0Q/WNs0xTxPkRHzHTC9yz/3BfD5g/kWwuVH2Sxl9SDcgS2ZioOkOML2VYdC0hZgBs636/Bc2wXAjqVJcgnpYsMqTtR35w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM8PR12MB5445.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(136003)(39860400002)(346002)(366004)(956004)(8936002)(66946007)(4744005)(5660300002)(86362001)(66476007)(66556008)(2616005)(36756003)(53546011)(316002)(8676002)(6486002)(26005)(4326008)(16576012)(110136005)(38100700002)(38350700002)(478600001)(52116002)(31686004)(31696002)(2906002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXJZYWFBa3MveTNQb2ZGR3NSWGZ6ZUorU0FsNW4yK3VqajdwMUh5bHdyNGRa?=
 =?utf-8?B?aGRZbEFSTG5jd0ZjVHN4WCs0bXJobHBKd1BqeURGQzNqaitpd2dmZDRDeHpD?=
 =?utf-8?B?dlZjRldzYW5sWlFsMjJCU1EyeFIrNVlWT2cvYkh4eUJ0SU1sSC9rbG5YVXBL?=
 =?utf-8?B?TGw5R3UzTFQzTmhCYi9icHRaeVBZQWRLT0FOYXNUa3FIQnEySlhWek83Q08v?=
 =?utf-8?B?TFJRbmp1eUZTZG5mSVBBVFpXK3Y5NE8yWUtNVENnbUNEUGlSalhzQ3dROWdx?=
 =?utf-8?B?WEU0OXZqYml3K1dpM09Nb093Rmw1RDhxNFpzUi84ckFQYzhHdWZXenpzWGNs?=
 =?utf-8?B?TDkzUVJyd0FESDZLMXJDcVRvK2NkU0tsN01IS1lnNGZjbDBDMTBHR2FVcGR5?=
 =?utf-8?B?VkxDb1JpUjU3cERZTGNWMUhYa3pwQWp5cjFETFA4ZWFNblcvRHhNL1pDODhW?=
 =?utf-8?B?czFwTFNtdUVyUE9ZRm5PZ0R2OURQczhBR3JBSW9zMmdsVE5RaTArWFdHRldm?=
 =?utf-8?B?cGFJZmxCVDFRSWYvaXRKcjB5Tm9ud05aMmlTTDA0WXN5YTVsWXhlb2d1RWdX?=
 =?utf-8?B?ZURCeFVLM3FFaHhQNmVRQ1RaR2ZHbzh1a3BnVFczWElKMzhFZkkvYzQ4NDNO?=
 =?utf-8?B?VWNHbEV5NG02OVppQi9tWHd1RnhjQUY4VjJCSGUyQ2FVYVE0bDU3WDhEdjR2?=
 =?utf-8?B?VmpMN1NwR0p0RlNkRHRybktGVkI4MUtUNzhPMExTdTVWTi90dlV0Q1ZaQXFX?=
 =?utf-8?B?d3ZRdGloWERlMWcrcnVLTnlTcFg1b0Y2QlRxK3dFOC94eG5TNm1oL2o5cU90?=
 =?utf-8?B?MFB4RFovU3NBQkRDT09HMEFFQ21hNGdyeHdpYWxYRURmdFBZMjRwUGo5dk1S?=
 =?utf-8?B?ajFleTZNcXF5d3hzQkhwTmtGK1FlREVOZnh4cTN2TEFTbllaam5QRmhsb0FO?=
 =?utf-8?B?OHBXZVM2ZWtxSmxtQUdObTZnTzJhSmMrd3VEQ1BpWkVYL0EyUFBtSHhqQ1Zl?=
 =?utf-8?B?VUhKUXcxditiaUZoNlZVTk9kTDIrN1IxdlNlZjlwbHA0S1FjaXc2cnhKRDdY?=
 =?utf-8?B?cEFHWXkvb0FMN1NDa2dwQ2dWYXZReUR4clRhOWxxYWxXeU1qS2NuVGZJSk0w?=
 =?utf-8?B?NUtvVHg3SDhhUzd4RVdCc0ZTVElJYkxRMzN0VFR6K0prZGh6VmIray9IL1Ax?=
 =?utf-8?B?eUtONURWWHFJRGlVOHhIK0JZK0J2TE9HdWdmOFVMejhKU3JMNVRGck1ycXBr?=
 =?utf-8?B?S2l5am05dmZiNlBwcytLVnNMS1hMTjlqTVA1THFGTUg2VnYxVklLN2RSak1S?=
 =?utf-8?B?Yk8vcERIQ2lyRGl4TUgweU9VbEFRcmd4cXh1VFVpaVFLa1RNeEtMQk1sUmpS?=
 =?utf-8?B?ZVFwaXgwcDFJOFRCOUxZZk45R29ZNkhmdTFRNHhCVG5CdnlaaUhRVXNFOEdT?=
 =?utf-8?B?ZVdzT2YrTTRjSWlLWUh0cGh0YWo5QjhyZ3gxeWdlaldCNVhETFBzQnpQcCtK?=
 =?utf-8?B?NTJJU2J4NkkrUG9jRHhRdXUwcFlFbmk3d2ZPdFppZThMNkVLOW5pVi9qMVpD?=
 =?utf-8?B?QU1IUTVIcUNnWDhtdklpVXlZT0RTQTlvNFh2VFhhZ0VqOE8vMk5ZMGlIVUEr?=
 =?utf-8?B?RjBuWGR3eG9iTUp3c0wwZndsekhmSFV6TFJVdHpSdVNPWTAzUDliNkJwOUVi?=
 =?utf-8?B?U0VkamRYZUZxN0J0K09mOHJlSmVpQVltc0I1c20xS1FXVUFGd2oxdnpwTFE0?=
 =?utf-8?Q?1c3fJEAQPY2/OBFt/4J1Q6/IvURbzTh3lu+p373?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89584513-c60d-4ca8-406f-08d94d47c8f5
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2021 19:34:56.1020
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jon6BoN3QPBrXH85HGjcIVrdsLdJvOyQjFfjDYwiMjwHwFHJ0GKbMmgV7Urg2k/Akn4oo9ymKV5gACbxkdtuSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5198
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/19/2021 3:32 AM, Xiyu Yang wrote:
> refcount_t type and corresponding API can protect refcounters from
> accidental underflow and overflow and further use-after-free situations.
> 
> Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>

Thanks,

Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>