Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 13/13] media: ipu3-cio2: Add INT347A to cio2-bridge
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        Ezequiel Garcia <ezequiel@collabora.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Yang Li <yang.lee@linux.alibaba.com>,
        "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" 
        <linux-media@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Yong Zhi <yong.zhi@intel.com>,
        Bingbu Cao <bingbu.cao@intel.com>,
        Tianshu Qiu <tian.shu.qiu@intel.com>,
        Colin Ian King <colin.king@canonical.com>,
        "laurent.pinchart@ideasonboard.com" 
        <laurent.pinchart@ideasonboard.com>,
        "kieran.bingham@ideasonboard.com" <kieran.bingham@ideasonboard.com>
References: <20210722203407.3588046-1-djrscally@gmail.com>
 <20210722203407.3588046-14-djrscally@gmail.com>
 <CAHp75Vc60J1kTs0Kv5ibc+5zqCTvRDDAcmHFKFDi-4Qd-rBHuA@mail.gmail.com>
From:   Daniel Scally <djrscally@gmail.com>
Message-ID: <339f54cb-6be1-1bfa-9b32-fe7dc28a447b@gmail.com>
Date:   Fri, 23 Jul 2021 00:07:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CAHp75Vc60J1kTs0Kv5ibc+5zqCTvRDDAcmHFKFDi-4Qd-rBHuA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hi Andy

On 22/07/2021 23:22, Andy Shevchenko wrote:
>
>
> On Thursday, July 22, 2021, Daniel Scally <djrscally@gmail.com
> <mailto:djrscally@gmail.com>> wrote:
>
>     ACPI _HID INT347A represents the OV8865 sensor, the driver for
>     which can
>     support the platforms that the cio2-bridge serves. Add it to the array
>     of supported sensors so the bridge will connect the sensor to the CIO2
>     device.
>
>     Signed-off-by: Daniel Scally <djrscally@gmail.com
>     <mailto:djrscally@gmail.com>>
>     ---
>      drivers/media/pci/intel/ipu3/cio2-bridge.c | 2 ++
>      1 file changed, 2 insertions(+)
>
>     diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c
>     b/drivers/media/pci/intel/ipu3/cio2-bridge.c
>     index 4657e99df033..6195abd7582c 100644
>     --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
>     +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
>     @@ -24,6 +24,8 @@ static const struct cio2_sensor_config
>     cio2_supported_sensors[] = {
>             CIO2_SENSOR_CONFIG("INT33BE", 0),
>             /* Omnivision OV2680 */
>             CIO2_SENSOR_CONFIG("OVTI2680", 0),
>     +       /* Omnivision OV8865 */
>     +       CIO2_SENSOR_CONFIG("INT347A", 1, 360000000),
>
>
> I assume it may be positioned at any index in the array. I prefer to
> see them sorted by HID


Yeah any position's fine; I seem to struggle with alphabetisation for
some reason :) No problem, I'll order them properly in v2.

>
>
>  
>
>      };
>
>      static const struct cio2_property_names prop_names = {
>     -- 
>     2.25.1
>
>
>
> -- 
> With Best Regards,
> Andy Shevchenko
>
>