Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Richard Zhu <hongxing.zhu@nxp.com>
To:     Rob Herring <robh@kernel.org>
CC:     dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "galak@kernel.crashing.org" <galak@kernel.crashing.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [RFC 1/2] dt-bindings: PCI: imx6: add fsl,imx6q-pcie.yaml
Thread-Topic: [RFC 1/2] dt-bindings: PCI: imx6: add fsl,imx6q-pcie.yaml
Thread-Index: AQHXftWTjxZ6H2iQ50qnn5J+AaCrS6tPEHIAgADSXYA=
Date:   Fri, 23 Jul 2021 03:11:39 +0000
Message-ID: <VI1PR04MB5853419B5BE2236E38AFB6918CE59@VI1PR04MB5853.eurprd04.prod.outlook.com>
References: <1626942155-9209-1-git-send-email-hongxing.zhu@nxp.com>
 <1626942155-9209-2-git-send-email-hongxing.zhu@nxp.com>
 <1626964632.949777.4183870.nullmailer@robh.at.kernel.org>
In-Reply-To: <1626964632.949777.4183870.nullmailer@robh.at.kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hG4PrnIjLyn2Y45AedzNRIPQdgW+oKEx+19gFArnbBqj8RmtcYiyJ5XUIvLM?=
 =?us-ascii?Q?oHYIrk1FOQMHYhHKot2rzZ9daBvHZA/QpQM3kgCvFex52nocjh2zJnNtXZ2z?=
 =?us-ascii?Q?tjSFZsKVSrXk2brA9LDZkIQkLq5OV10mkR0mrI6hvq0hdsHTd9AvfUYCos/i?=
 =?us-ascii?Q?+oSBTI3ujW9iROXtcu9u5QPI1vRtYrOKLbzRJjMBrFMUKEBXazAxnk7SjINR?=
 =?us-ascii?Q?k2Jv4Nf4WtNk6xJVLzxdC8TXvT4EkRvacjh7iYvulRv98RnUJ6stqTmuix/+?=
 =?us-ascii?Q?itUMIjOF+RCLSVdBEQ+SroLIPvuSY0BQbvZ82ch4v+BfpJ76JzOKo/zmhneB?=
 =?us-ascii?Q?xcUMj+PZ7fCkCBKYdGLWalZMvPkOP2KbuSbFB/FUxQsFnFdtO/T5KFE7f+VF?=
 =?us-ascii?Q?xqwxWTGClTphy0KvJn4vTdFxKmWpnn/jc1PA5SuSt81MYcpI0PK/8tz7ZA4d?=
 =?us-ascii?Q?KaIr1P44iO4ITM2CKg6WErMTtVl9zS+7ruXPlsUcJfP98iZCGTEAiS0LAp7N?=
 =?us-ascii?Q?wq6YwYrE77TwafTX/sZGykbtpYTxDhgPsswKAWv9PSvX+uL73dApxtK8sHQA?=
 =?us-ascii?Q?VkUnhCZoUPntFvhvmv1Cl/cKhXJ4wqEnfcx4hJpqzbTNBRKkvtCroRXijV/3?=
 =?us-ascii?Q?dpwXCXihvJQdjUOwfWZaNUN4dmjsNBsyeoQ+5Fo+I3s0wyFCSa+0M4BMbQQU?=
 =?us-ascii?Q?0wupVPN6YXkLSBkbVqwij7/x4vZMO6lWOVHZXs+nEEC74fLq9K5p+nE5Mb14?=
 =?us-ascii?Q?sXSJ5TGU6V0IaoSJo8s9GSr2yULgKmlOOyUyVkckxOQsUT91Yp62rkTUb1fQ?=
 =?us-ascii?Q?Y5d32IuQhBx9dZW5tku5tpdJPU90kf6JszPeCIk6cHSyktl7VVYTT9KIwyDz?=
 =?us-ascii?Q?VrB0kRv1y+B8VUpAUT6Gsii+LFWc4KB/8qkze3N0puGg4FgORbVHISlt4Bc4?=
 =?us-ascii?Q?m5bheMbiPRmI4LRW5K/r36VApeJZ9hFJ24MCMZK1WX7V5xbSTanJr8+vK2xf?=
 =?us-ascii?Q?jT0vF2ymqKLHTpyF4ZE6bV6lhV6qZuZFyM0Ovw1713+yMJsKH0fUC1lfsVSQ?=
 =?us-ascii?Q?M58Dz65g0faOoyllBl3tFdNZY0dTVYySnWC9yeE1YItwlOF+a0lzrggrnG6D?=
 =?us-ascii?Q?cqi09kcmxZpp7V4/qpc7lY1qJk+QsaVD1PAH+maP6Kw1qfmRTHCOPqTgvFN2?=
 =?us-ascii?Q?kNzbSZS71UOYbe8fRlG+9eTiUzC7SJs1BSiNIPRHhqtR5LDu/whucQVYEM5F?=
 =?us-ascii?Q?cXQKvf6ymGCHDKjd5gD+KoFF7y1VqDQyjv1/gFAN25HtZWxiGb7lGhapofck?=
 =?us-ascii?Q?cutrQP/C8trIrJ5KW+vcK5pr?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5853.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51f87b7b-612d-4740-ecb0-08d94d87970c
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2021 03:11:39.8756
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: agogNYq7+ebu23Bi/ren0WOBckV/AYAUNc8lm7FMhVdDrXeNF6QCgiFRb9wXXaV70FToWTnlBNnlT161eP9Xlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6704
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Thursday, July 22, 2021 10:37 PM
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.or=
g;
> l.stach@pengutronix.de; galak@kernel.crashing.org; shawnguo@kernel.org;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [RFC 1/2] dt-bindings: PCI: imx6: add fsl,imx6q-pcie.yaml
>=20
> On Thu, 22 Jul 2021 16:22:34 +0800, Richard Zhu wrote:
> > Convert the fsl,imx6q-pcie.txt into a schema.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
> >  .../bindings/pci/fsl,imx6q-pcie.yaml          | 212
> ++++++++++++++++++
> >  MAINTAINERS                                   |   1 +
> >  2 files changed, 213 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> >
>=20
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>=20
> yamllint warnings/errors:
>=20
> dtschema/dtc warnings/errors:
> make[1]: *** Deleting file
> 'Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dts'
> Traceback (most recent call last):
>   File "/usr/local/bin/dt-extract-example", line 45, in <module>
>     binding =3D yaml.load(open(args.yamlfile, encoding=3D'utf-8').read())
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line
> 434, in load
>     return constructor.get_single_data()
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 122, in get_single_data
>     return self.construct_document(node)
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 132, in construct_document
>     for _dummy in generator:
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 722, in construct_yaml_map
>     value =3D self.construct_mapping(node)
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 446, in construct_mapping
>     return BaseConstructor.construct_mapping(self, node, deep=3Ddeep)
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 264, in construct_mapping
>     if self.check_mapping_key(node, key_node, mapping, key, value):
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 295, in check_mapping_key
>     raise DuplicateKeyError(*args)
> ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
>   in "<unicode string>", line 22, column 5 found duplicate key "const" wi=
th
> value "fsl,imx6sx-pcie" (original value: "fsl,imx6q-pcie")
>   in "<unicode string>", line 23, column 5
>=20
> To suppress this check see:
>=20
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fyaml.r=
e
> adthedocs.io%2Fen%2Flatest%2Fapi.html%23duplicate-keys&amp;data=3D04%
> 7C01%7Chongxing.zhu%40nxp.com%7C6171b22cdb104315be0d08d94d1e36
> 3f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6376256144309
> 20703%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l
> uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D4Mu4S%2B6
> KeTg4gaCCL2Q%2ByjO7FbENp5LGHVRPuBhtvCc%3D&amp;reserved=3D0
>=20
> Duplicate keys will become an error in future releases, and are errors by
> default when using the new API.
>=20
> make[1]: *** [Documentation/devicetree/bindings/Makefile:20:
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dts] Error 1
> make[1]: *** Waiting for unfinished jobs....
> Traceback (most recent call last):
>   File "/usr/local/bin/dt-doc-validate", line 67, in <module>
>     ret =3D check_doc(f)
>   File "/usr/local/bin/dt-doc-validate", line 25, in check_doc
>     testtree =3D dtschema.load(filename, line_number=3Dline_number)
>   File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 623=
, in
> load
>     return yaml.load(f.read())
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line
> 434, in load
>     return constructor.get_single_data()
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 122, in get_single_data
>     return self.construct_document(node)
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 132, in construct_document
>     for _dummy in generator:
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 722, in construct_yaml_map
>     value =3D self.construct_mapping(node)
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 446, in construct_mapping
>     return BaseConstructor.construct_mapping(self, node, deep=3Ddeep)
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 264, in construct_mapping
>     if self.check_mapping_key(node, key_node, mapping, key, value):
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 295, in check_mapping_key
>     raise DuplicateKeyError(*args)
> ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
>   in "<unicode string>", line 22, column 5 found duplicate key "const" wi=
th
> value "fsl,imx6sx-pcie" (original value: "fsl,imx6q-pcie")
>   in "<unicode string>", line 23, column 5
>=20
> To suppress this check see:
>=20
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fyaml.r=
e
> adthedocs.io%2Fen%2Flatest%2Fapi.html%23duplicate-keys&amp;data=3D04%
> 7C01%7Chongxing.zhu%40nxp.com%7C6171b22cdb104315be0d08d94d1e36
> 3f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6376256144309
> 20703%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l
> uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D4Mu4S%2B6
> KeTg4gaCCL2Q%2ByjO7FbENp5LGHVRPuBhtvCc%3D&amp;reserved=3D0
>=20
> Duplicate keys will become an error in future releases, and are errors by
> default when using the new API.
>=20
> make[1]: *** Deleting file
> 'Documentation/devicetree/bindings/processed-schema-examples.json'
> Traceback (most recent call last):
>   File "/usr/local/bin/dt-mk-schema", line 38, in <module>
>     schemas =3D dtschema.process_schemas(args.schemas,
> core_schema=3D(not args.useronly))
>   File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 585=
, in
> process_schemas
>     sch =3D process_schema(os.path.abspath(filename))
>   File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 558=
, in
> process_schema
>     schema =3D load_schema(filename)
>   File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 125=
, in
> load_schema
>     return do_load(os.path.join(schema_basedir, schema))
>   File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 111=
, in
> do_load
>     return yaml.load(f.read())
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line
> 434, in load
>     return constructor.get_single_data()
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 122, in get_single_data
>     return self.construct_document(node)
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 132, in construct_document
>     for _dummy in generator:
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 722, in construct_yaml_map
>     value =3D self.construct_mapping(node)
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 446, in construct_mapping
>     return BaseConstructor.construct_mapping(self, node, deep=3Ddeep)
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 264, in construct_mapping
>     if self.check_mapping_key(node, key_node, mapping, key, value):
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py=
",
> line 295, in check_mapping_key
>     raise DuplicateKeyError(*args)
> ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
>   in "<unicode string>", line 22, column 5 found duplicate key "const" wi=
th
> value "fsl,imx6sx-pcie" (original value: "fsl,imx6q-pcie")
>   in "<unicode string>", line 23, column 5
>=20
> To suppress this check see:
>=20
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fyaml.r=
e
> adthedocs.io%2Fen%2Flatest%2Fapi.html%23duplicate-keys&amp;data=3D04%
> 7C01%7Chongxing.zhu%40nxp.com%7C6171b22cdb104315be0d08d94d1e36
> 3f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6376256144309
> 20703%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l
> uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D4Mu4S%2B6
> KeTg4gaCCL2Q%2ByjO7FbENp5LGHVRPuBhtvCc%3D&amp;reserved=3D0
>=20
> Duplicate keys will become an error in future releases, and are errors by
> default when using the new API.
>=20
> make[1]: *** [Documentation/devicetree/bindings/Makefile:62:
> Documentation/devicetree/bindings/processed-schema-examples.json] Error
> 1
> make: *** [Makefile:1418: dt_binding_check] Error 2 \ndoc reference error=
s
> (make refcheckdocs):
>=20
> See
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpatch
> work.ozlabs.org%2Fpatch%2F1508586&amp;data=3D04%7C01%7Chongxing.zhu
> %40nxp.com%7C6171b22cdb104315be0d08d94d1e363f%7C686ea1d3bc2b4
> c6fa92cd99c5c301635%7C0%7C0%7C637625614430920703%7CUnknown%
> 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW
> wiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D1x%2BNE6KyvoYSRAPFxPVXKYu4
> Md59o%2F9CtEKqaCsOwuU%3D&amp;reserved=3D0
>=20
> This check can fail if there are any dependencies. The base for a patch s=
eries
> is generally the most recent rc1.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above error=
(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>=20
> pip3 install dtschema --upgrade
>=20
> Please check and re-submit.
[Richard Zhu] Got that. Thanks for your help. Will submit the patch-set aft=
er the errors are fixed.

Best Regards
Richard Zhu