Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1055780pxv;
        Thu, 22 Jul 2021 21:06:12 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwRbvmcpT8NFY/fxP0d8i8vnYJdV6qiOealI6Y1uTYvJpZnoK59+0NZIIn0YGac3ndDOqEf
X-Received: by 2002:a17:906:4f14:: with SMTP id t20mr2834341eju.12.1627013172114;
        Thu, 22 Jul 2021 21:06:12 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1627013172; cv=none;
        d=google.com; s=arc-20160816;
        b=ZwX/FCmI1uBv7zeFS7wMXsb5W/SZXm+90tgRrvZ3oB9Pul5gZPDKnb7GH+Rzgki37W
         Kr1+Ma5MTvOQtGS+ZiASTRZjdmCdObwIw9nt1x38sXI+U4AX+IC4yIPpV6plIFsTdt6Y
         iCjRJh+Y7xb5ua3YG+nMxYKefrIv3HVgg5e/EuGLv1yWDXB+XRxOra3xtcWTRgWXfkgy
         Dy2EbLUNTZrFMnS71mbc1w5clvZGbBrmnCHHQKPVClu1y1WL4k8jo4nqgchYu2AhjqBl
         wncsqEstnMiJDD50NRLHYrA5z4lp91Nou7m0EJ7AaqzLFuofEqyx50Imy/kVturo2A9J
         34kQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:content-language
         :in-reply-to:mime-version:user-agent:date:message-id:from:references
         :to:subject;
        bh=UAWfR33VLIl1+ExtgDEUKbhH50naiTNGx3i52j7b1uA=;
        b=fgw69BpPISxbe43WkZeSNy86cP3Y2MhAatY9dxK9tSijdURNj6sMOoDwE9R0WEfjBF
         ZDaBJyVDMHeshGOZ5whRr+l4Ib75eZP39fdKMmNXQDTljAtTJ8BhAuVuLiZ0TwAHEd1e
         Qq5teBp5763jnt/ALyrl+2ssaD4lYlXLeQvkaW2lAYTUN9hL78zrIhFU+57w9HfPQhO1
         TR4RLddfC41OFW5wT5/bnCvm9YZcq2hS21VTm7OV49gI8qF555m6pwtcEgvE5AC/uRmi
         hsb/tXenmcxwPxF4vy/Zq14RT1Xe9Hnt0Dw6VW6Y+szOlnlclUccuyqlnqn+5yTiCyd4
         sYtQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id w19si31906641edv.129.2021.07.22.21.05.49;
        Thu, 22 Jul 2021 21:06:12 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234781AbhGWDXz (ORCPT <rfc822;linuxntwrk@gmail.com> + 99 others);
        Thu, 22 Jul 2021 23:23:55 -0400
Received: from mail-pl1-f170.google.com ([209.85.214.170]:35509 "EHLO
        mail-pl1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234165AbhGWDXs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 22 Jul 2021 23:23:48 -0400
Received: by mail-pl1-f170.google.com with SMTP id e10so1834193pls.2;
        Thu, 22 Jul 2021 21:04:22 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=UAWfR33VLIl1+ExtgDEUKbhH50naiTNGx3i52j7b1uA=;
        b=JmNq/uV8XW0coFhmS6yraCeKgD9u/5gmW/r55ZBnXDhEzPJhB/GSMhiuv5Y7aI14w0
         m2q7BMEI+P8VuNQxTqQdvIUuuxXVTwRNesajVuDazNgC0QfIW8lXNEAyqOGy3O2hQzkO
         IHp7IbYjANH6ve0M3c3fzNbCxZnmcL4OVy0nzHK/nelAOGzOnQ9hdorsheezGnOzt7od
         lNdQG09+R8C2IjTDWXiuYXpwt25VfxkBdK6pN0dmq50ZUKJhsXDvEHLDjZYLSqK+iYcE
         r35dTN3z8gqGM6DiVXJ7E53e0DOb2AAw+WIjY1rDUxy6WDeiw33b+oRVuAAh5Nk9/FLl
         TDYA==
X-Gm-Message-State: AOAM531fuxS+b2StCIiF4y2LvyhZSXj7vGpFeFEXhhYgKiGm5lFeU9UB
        Xty8wR6acDqVOGmSMs4v46esq2NgK14a8w==
X-Received: by 2002:a05:6a00:ac8:b029:320:a6bb:880d with SMTP id c8-20020a056a000ac8b0290320a6bb880dmr2676447pfl.41.1627013061027;
        Thu, 22 Jul 2021 21:04:21 -0700 (PDT)
Received: from ?IPv6:2601:647:4000:d7:286e:6a9d:f340:dcd9? ([2601:647:4000:d7:286e:6a9d:f340:dcd9])
        by smtp.gmail.com with ESMTPSA id c83sm6898990pfb.164.2021.07.22.21.04.19
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Thu, 22 Jul 2021 21:04:20 -0700 (PDT)
Subject: Re: [PATH v2] scsi: scsi_dh_rdac: Avoid crash during rdac_bus_attach
To:     Ye Bin <yebin10@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210113063103.2698953-1-yebin10@huawei.com>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <a1113b04-e320-a12b-5a59-ec7479d5eec1@acm.org>
Date:   Thu, 22 Jul 2021 21:04:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210113063103.2698953-1-yebin10@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/12/21 10:31 PM, Ye Bin wrote:
>  	sdev->handler_data = NULL;
> +	synchronize_rcu();
>  	kfree(h);

What is the purpose of the new synchronize_rcu() call? If its purpose is
to wait until *h is no longer in use, please use kfree_rcu() instead.

Thanks,

Bart.