Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] extcon: usb-gpio: Use the right includes
To:     Linus Walleij <linus.walleij@linaro.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>
Cc:     linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <393ac5f7-bd50-d36b-6b33-8ed74be11eea@samsung.com>
Date:   Fri, 23 Jul 2021 14:47:52 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <20210715190606.429251-1-linus.walleij@linaro.org>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20210715195441epcas1p2902263d7e7aeec6213a7ba554eff2695@epcas1p2.samsung.com>
        <20210715190606.429251-1-linus.walleij@linaro.org>
Precedence: bulk

On 7/16/21 4:06 AM, Linus Walleij wrote:
> The USB GPIO extcon driver does not use any of the legacy
> includes <linux/gpio.h> or <linux/of_gpio.h> but
> exploits the fact that this brings in <linux/mod_device_table.h>.
> Fix this up by using the right includes.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/extcon/extcon-usb-gpio.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index f06be6d4e2a9..0cb440bdd5cb 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -7,18 +7,17 @@
>   */
>  
>  #include <linux/extcon-provider.h>
> -#include <linux/gpio.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/init.h>
>  #include <linux/interrupt.h>
>  #include <linux/irq.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/of_gpio.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/workqueue.h>
>  #include <linux/pinctrl/consumer.h>
> +#include <linux/mod_devicetable.h>
>  
>  #define USB_GPIO_DEBOUNCE_MS	20	/* ms */
>  
> 

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics