Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1133744pxv; Fri, 23 Jul 2021 00:03:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyL65+kK+RhwwcAyw+xbpozhn6k9APXcJR+7bAqtkjC5l1BVpJ1UdQlU4TLNqlrSTBrBbt0 X-Received: by 2002:a17:906:5fc1:: with SMTP id k1mr3285892ejv.360.1627023837676; Fri, 23 Jul 2021 00:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627023837; cv=none; d=google.com; s=arc-20160816; b=kXbTVkwKkN9a1YDJYox0q+75U0EJ/NQpzwFHxapQihRTk9J5nHGAPjLHH5EvPwwokd jGVOtmpr+lvYJz8cf4zum61HPuvWc7c96vMtpYb13oAkjrKN84tDVXJnMBj1AaR+YjIY SIPl2blXAK6bvJ7gTzj7/TiSQGqk/xBCFiU1r0R98jruTiQbq/XGc7nvkHIWLiAbsNsg B9b8XCoXo6QKy75Eyhv3rxORkRqxyzZ7e91lPNBK2aDc6QLL3KL1+93eUxnntKeQ6pyc VrD0IFpNn1Ai37rEvj4bDEA1eyumEMK2m3k3LPyD8VLQrz1IzUL9gUUitdobqIvI3jNd M8lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hBFDQ9boO/fjedOGrC8gsvX2Ia4g17LhLefDr26cgDg=; b=thH1Gw4jO2C7jzM2I6RCnOleVcbAFXeF8Eqli8dLZFypf1JPze0TKAo8piWA+b+vEN INn1Yz5BCvWF+EC/t2eb7JY8OyBOQTwH2ejXq10QJju05AcGiG/IawsV8avrXDRvnk6o fAl9S64KxnpryKolb1CF+61nBtIniVLwCuZEOYkBjxQp4YTYeTMCxOKxJYJTP+5i3Ly6 LxKu5W8XgiwVjn2mVA10y62KzPD1zm1mnxGEu2+o659ieA2RtOmcV4Bu/FokY+zBDQyu Kvpu3YXs8KE/XbWGCeTPdgn7Uty1338hKmuHStqY4o3wuBeIeEuVDK5ii9GWE29pu7zn y8vQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oYElD2rh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mp33si21892746ejc.40.2021.07.23.00.03.33; Fri, 23 Jul 2021 00:03:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oYElD2rh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234196AbhGWGVf (ORCPT + 99 others); Fri, 23 Jul 2021 02:21:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:57978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234089AbhGWGVe (ORCPT ); Fri, 23 Jul 2021 02:21:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F252A60EE2; Fri, 23 Jul 2021 07:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627023728; bh=02LUfP9gRBAKznttDT6gEA8Wm5l4jpvhTQOhmSmp6TY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oYElD2rhN77kwhk3cHbdJs1c1K4EEL9wI8fe4Uw3mOaPEtxJSMnhDjUPbEEf1SAzA YEHykz6fGqLgjZZ4asnYJ3GIswCFOu2g/Z98w+hF9lyqReoghUDstiJGuK44r8OyR6 EhDzQXwJgbKvoHxsJjXUSHkuXAx5ulAcvQyMelNA= Date: Fri, 23 Jul 2021 09:02:05 +0200 From: Greg KH To: Miaohe Lin Cc: Matthew Wilcox , Zhouyi Zhou , Chris Clayton , Oleksandr Natalenko , Boqun Feng , paulmck@kernel.org, linux-kernel , stable@vger.kernel.org, Chris Rankin , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , rcu , Andrew Morton , Linux-MM , "Huang, Ying" Subject: Re: linux-5.13.2: warning from kernel/rcu/tree_plugin.h:359 Message-ID: References: <2237123.PRLUojbHBq@natalenko.name> <01fef2db-bd7e-12b6-ec21-2addd02e7062@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01fef2db-bd7e-12b6-ec21-2addd02e7062@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 23, 2021 at 09:51:09AM +0800, Miaohe Lin wrote: > On 2021/7/22 22:00, Greg KH wrote: > > On Thu, Jul 22, 2021 at 03:26:52PM +0200, Greg KH wrote: > >> On Thu, Jul 22, 2021 at 01:36:02PM +0100, Matthew Wilcox wrote: > >>> On Thu, Jul 22, 2021 at 04:57:57PM +0800, Zhouyi Zhou wrote: > >>>> Thanks for reviewing, > >>>> > >>>> What I have deduced from the dmesg is: > >>>> In function do_swap_page, > >>>> after invoking > >>>> 3385 si = get_swap_device(entry); /* rcu_read_lock */ > >>>> and before > >>>> 3561 out: > >>>> 3562 if (si) > >>>> 3563 put_swap_device(si); > >>>> The thread got scheduled out in > >>>> 3454 locked = lock_page_or_retry(page, vma->vm_mm, vmf->flags); > >>>> > >>>> I am only familiar with Linux RCU subsystem, hope mm people can solve our > >>>> confusions. > >>> > >>> I don't understamd why you're still talking. The problem is understood. > >>> You need to revert the unnecessary backport of 2799e77529c2 and > >>> 2efa33fc7f6e > >> > >> Sorry for the delay, will go do so in a minute... > > > > Both now reverted from 5.10.y and 5.13.y. > > > > I browsed my previous backport notifying email and found that these two patches are also > backported into 5.12. And it seems it's missed. 5.12 is now end-of-life, it's not being touched anymore, and no one should continue to use it. thanks, greg k-h