Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210723004214.912295-1-phil@philpotter.co.uk> <630e139c-85e5-f006-6b64-e368847251fc@lwfinger.net>
In-Reply-To: <630e139c-85e5-f006-6b64-e368847251fc@lwfinger.net>
From:   Phillip Potter <phil@philpotter.co.uk>
Date:   Fri, 23 Jul 2021 08:29:22 +0100
Message-ID: <CAA=Fs0k0eQUpDgpxEcLAnZ-d87TM3LgPwPt9ydXO_hf39f_9ig@mail.gmail.com>
Subject: Re: [PATCH 0/7] staging: rtl8188eu: replace driver with better version
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-staging@lists.linux.dev, Fabio Aiuto <fabioaiuto83@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 23 Jul 2021 at 02:56, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
> On 7/22/21 7:42 PM, Phillip Potter wrote:
> > I had to break this patchset up a bit to get around the file size limits
> > on the mailing list, and also I removed the hostapd stuff which is
> > userspace related and therefore not required.
> >
> > The driver currently in staging is older and less functional than the
> > version on Larry Finger's GitHub account, branch v5.2.2.4. This series
> > of patches therefore:
> >
> > (1) Removes the current driver from staging.
> > (2) Imports the GitHub version mentioned above in its place.
> >
> > There is plenty of work to do to this driver, including to its Makefile,
> > but it is at least buildable/usable for now.
> >
> > Phillip Potter (7):
> >    staging: rtl8188eu: remove existing staging driver
> >    staging: rtl8188eu: introduce new core dir for RTL8188eu driver
> >    staging: rtl8188eu: introduce new hal dir for RTL8188eu driver
> >    staging: rtl8188eu: introduce new os_dep dir for RTL8188eu driver
> >    staging: rtl8188eu: introduce new include dir for RTL8188eu driver
> >    staging: rtl8188eu: introduce new supporting files for RTL8188eu
> >      driver
> >    staging: rtl8188eu: attach newly imported driver to build system
>
> Phillip,
>
> Patch 3/7 fails with a
> drivers/staging/rtl8188eu/hal/phydm_precomp.h: already exists in error:
> working directory. When I deleted the file, the patch applied.
>
> Patch 5/7 fails with a drivers/staging/rtl8188eu/include/hal_data.h: already
> exists in working directory. Again it applied when I manually deleted that file.
>
> Patches 2-6 all have trailing whitespace warnings.
>
> I have started testing. Unfortunately, my GitHub version has a fault in that it
> runs systemd-udevd at 100% of a CPU. So far, I have found that an older commit
> works fine. As soon as I find the fault, I will let you know.
>
> Larry
>
>
>
Dear Larry,

I obviously screwed up here somewhere as there should be no whitespace
or conflicts, so apologies for that. I will do the patch set again
after work when I've heard back from you about the relevant commit,
and send out again.

Regards,
Phil