Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756000AbWKVRTv (ORCPT ); Wed, 22 Nov 2006 12:19:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756015AbWKVRTv (ORCPT ); Wed, 22 Nov 2006 12:19:51 -0500 Received: from wr-out-0506.google.com ([64.233.184.238]:63610 "EHLO wr-out-0506.google.com") by vger.kernel.org with ESMTP id S1756000AbWKVRTu (ORCPT ); Wed, 22 Nov 2006 12:19:50 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=P03TVFen1FGRdn+pvmz5Nsx5Z+tuTxWeialRhW1Ex7Cv7ncl4jdz9JEt787xen+AZq4OO2goJOq8ZkkF41wLIDQPAdNKdozaLmQMUbd4V87wlMh36bmfg7xXeSAHUplWNBAoWMKOGSgYF2A98sCjUrNqM6KSOISAh7LXi2TIX1s= Message-ID: Date: Wed, 22 Nov 2006 18:19:49 +0100 From: wbrana@gmail.com To: "Andrew Morton" Subject: Re: [PATCH] snd-hda-intel: fix insufficient memory Cc: linux-kernel@vger.kernel.org, "Jaroslav Kysela" , "Takashi Iwai" In-Reply-To: <20061121224613.548207f9.akpm@osdl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20061121224613.548207f9.akpm@osdl.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1827 Lines: 39 Module uses shorter buffer if memory isn't sufficient. It doesn't change size of allocated memory automatically. User has to change it with command like this: echo 256 > /proc/asound/card0/pcm0p/sub0/prealloc I can change it, but many regular users don't know it. This card is used in new PCs, which have at least 256 MB RAM. 256 kB shouldn't be too much. Whole block isn't used if it isn't needed. On 11/22/06, Andrew Morton wrote: > On Tue, 21 Nov 2006 21:33:29 +0100 > wbrana@gmail.com wrote: > > > Module allocates insufficient memory for multichannel and high quality > > audio (96 kHz, 24 bit) > > Patch for 2.6.19-* changes default/maximal size from 64/128 to 256/4096 kB. > > > > --- sound/pci/hda/hda_intel.c.orig 2006-09-29 13:40:36.000000000 +0200 > > +++ sound/pci/hda/hda_intel.c 2006-11-05 16:45:13.000000000 +0100 > > @@ -1270,5 +1270,5 @@ > > snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV, > > snd_dma_pci_data(chip->pci), > > - 1024 * 64, 1024 * 128); > > + 1024 * 256, 1024 * 4096); > > chip->pcm[pcm_dev] = pcm; > > if (chip->pcm_devs < pcm_dev + 1) > > This was recently increased, but not by such a large amount: > > snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_DEV, > snd_dma_pci_data(chip->pci), > 1024 * 64, 1024 * 1024); > > is that sufficient? > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/