Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Jul 2021 11:10:34 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Yizhuo <yzhai003@ucr.edu>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Juan Antonio Aldea-Armenteros <juant.aldea@gmail.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] media: atomisp: fix the uninitialized use and rename
 "retvalue"
Message-ID: <20210723081034.GD1931@kadam>
References: <20210723085145.1ce7ee5c@canb.auug.org.au>
 <20210723003607.64179-1-yzhai003@ucr.edu>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210723003607.64179-1-yzhai003@ucr.edu>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNAP275CA0039.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.29 via Frontend Transport; Fri, 23 Jul 2021 08:10:50 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b8c95953-7403-4def-9c40-08d94db1657d
X-MS-TrafficTypeDiagnostic: CO1PR10MB4691:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB46917695C9A387ED79A3643C8EE59@CO1PR10MB4691.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: o2UMpgTqw0pN5DQyCa2vGy5cpvI+C1NrRTRktFIHu0lmSJgc+6pmNb+YYvfWT6y3ZD1c8KKxMFdH5kikKeqECFOoW/DA0192vLP4giW5S4CHKpQU9NPAICnfqt77drMGioUipTX+Uyj8zw+U93oHVEtUJdK3/WMtXIzbeHHtmt+LFcL9NqeJ4KxWatRz9Ajc4k1UXkPfoFZ4vWitDQtMEy9n6FLJKun1rH4G14M/qY4coIqMop48xPwFDIcBdNH8d37hai3opPkr2WtEIjk9UsqpSyqfp9ewAPJYVUCtzALnJrsPG3aFl877bepwtKmPVZMEn23rsHPfDWCov5GJjyCfMBuRaDXhY6dYp+H7K4rASSUaR0EwQqQ3slaAehsTB9lzKJ45ombQ/DjhEZAyPd+wjTzwY/fmNqmiACe+a912QVCnpNgRQDX9KZR19NiBRh4PcdfD9DXhIxRmetNaqeRTMG1SM49KYzyRB8JOUvmmSsQ0Ro4fJ1xCYWTGhoAMxnGElvgG+Qv2QNSQh/QdULyChRiNatrF+MTcuXzbnv38/COpwpKlS7CbdoQ3L5lFwoqoxhKU0xNZHNeXZ/PP5lJJe3T1tpUDJECo1b+RvJAolhM9pc9YeVD1K2A9x7nX756OHoW7ukOw1TRWAnZD5jCtu4PX2tvznUQRpiQUJvAtvyuL6nK76c6L3eIQouz8n8EVBXburwG6SQNm7P1udA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(6496006)(316002)(54906003)(4744005)(1076003)(52116002)(44832011)(2906002)(5660300002)(38350700002)(38100700002)(508600001)(86362001)(83380400001)(33656002)(8936002)(8676002)(55016002)(9576002)(33716001)(956004)(26005)(66946007)(66476007)(4326008)(6666004)(66556008)(9686003)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UXoTOdcTdCt1GjnuwN9cmo/lnFLJwUZ98khhGRjeMU9T3Jw+E39R1iLXkhqq?=
 =?us-ascii?Q?0JCHakr5ki1G1X+Cy78B6p3RR9JTp1YeDdPUdCc64+UO7Evr+RuzE8uL7W6M?=
 =?us-ascii?Q?m4VgE0gf3TMwY/C8OWrj8TPaqPA4ihdRJeU+YZf7nsCMhr4J5q5rKi6fmR+7?=
 =?us-ascii?Q?39pRYgMPo+928Ud+gp+M8SQEChza7JucVN/NkwwMzE9uceTsw34KxU1EwfXR?=
 =?us-ascii?Q?yAiD4B6CQiV86JDREJ7EjT1uyR+v7speWx2YFo47IIa/zH1NoF4nMXTkpQ69?=
 =?us-ascii?Q?f2QX8as73GtdZ0RXfEHV11JzCkWfHUWuOeobDgM4kLkrYIucydyTbxZhBe5C?=
 =?us-ascii?Q?jE3GgqMGnqvIklO8FpqE463L5+vJ5nqs8yIgBOK2sKDOVZ73R2bnhl67Ky33?=
 =?us-ascii?Q?WjgkeGzajUW4J2PVFOTgfX2wPaRf+2D3xWN6CF6FQgdsuS7b2/uNakaulsiO?=
 =?us-ascii?Q?pmQvvE6DQUA29N6x53NpjzmESqVCaekv/Vy7iHkW4/8gk28tIJETDMe+gGWt?=
 =?us-ascii?Q?YP4Jc2h81G+IbLtK3W88O2oPths+vTQnTfxnWFYlGjb9gXzezmGCKMM8ocli?=
 =?us-ascii?Q?O4TXyY2s3Z9YZzxGBS4vdkzTvtV1TQhQ/NTFu252zjWZOYBZ+YiYZLyVwVul?=
 =?us-ascii?Q?Vo0ZLDmvK+ukmpTKFOkvOPx/trwMeblv7lqaKC0GbiAVG10lqGCmKYtLhlO6?=
 =?us-ascii?Q?UyUEF8mJ+xxr+4H+7rUxD2ke+zhoq6fctdlkq3wDjGNAUuC9ggNuDZsyBph3?=
 =?us-ascii?Q?fFUzonvtoxQmJRYOCiBihCW6n5vVFt5au7cSoFogj0yIe+cgCJ4hsO2Bvx3o?=
 =?us-ascii?Q?cRwczrYQijkbPo5c/c101ZsxeXM3RsSYxa5GX0HAP8kqOiAbjmMeqCS4Y0/n?=
 =?us-ascii?Q?CZZqiqVhnikAdhQsuKxyfT25cTcB3/3KXd6UmT0R+Msvx1bc5oxR7bWhtCvJ?=
 =?us-ascii?Q?U29USIk2nK6+tlZdU40QpUv4QT1yM9eg8EjCSRgtYrodu/1SOFPCmKw5S9pG?=
 =?us-ascii?Q?Hynm5Oi3noQBJm89piL8Mc++M0yQpUTph/S3I1mfgqZVjnLVd79RFWZ5Lj63?=
 =?us-ascii?Q?U+N6x3hW4YxkkVkOYE/GQ2tabNZDea8pXGRFvWfzb5mINcwkRnl3Lo9z92cq?=
 =?us-ascii?Q?JDnJ/6VouZ1kU67Fh4rRnLtV/0H6cSso6PPzPiKkyMa3cxZPP3lIkzBMm4rO?=
 =?us-ascii?Q?QIIrkxOMNtVy4lB3q4HckhQQ4l/ySQfVbcD9iA2rH9UMiL/GjxpKKjR1zcgz?=
 =?us-ascii?Q?5dTIvPNF4+QFbFpEV1bXDS2C3wT+Ol99k+FUS0oF7MriUHnNuNcro+QLSAjt?=
 =?us-ascii?Q?XEMJG1mF/QWD3wfU8+N/smNe?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b8c95953-7403-4def-9c40-08d94db1657d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2021 08:10:56.3822
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JBEjkMzyoXCmXui6gFjs4QKHX3p5VNTu8Tgp2yNasBV0YkS0vkDsUgrCJ23UudKZ2PguDnqcKHWjikCqpRipudv6idwZIIkgQ6rbbur1WR0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4691
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10053 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0
 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107230047
X-Proofpoint-ORIG-GUID: KVy6VQzOlVy4vQQRw4_JXPmEMsOJinPp
X-Proofpoint-GUID: KVy6VQzOlVy4vQQRw4_JXPmEMsOJinPp
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 23, 2021 at 12:36:04AM +0000, Yizhuo wrote:
> Inside function mt9m114_detect(), variable "retvalue" could
> be uninitialized if mt9m114_read_reg() returns error, however, it
> is used in the later if statement, which is potentially unsafe.
> 
> The local variable "retvalue" is renamed to "model" to avoid
> confusion.
> 
> Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
> ---

Is your full name just Yizhuo or Yizhuo Zhai?  Please use your legal
name as if you were signing a legal document.

I don't think you have changed anything in this version?  It's basically
a resend of the patch from Jun 25?  Please put that information under
the --- cut off.

Looks okay to me.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter