Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Jul 2021 11:44:59 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Corey Minyard <minyard@acm.org>
Cc:     Quan Nguyen <quan@os.amperecomputing.com>,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] ipmi: ssif_bmc: Return -EFAULT if copy_from_user() fails
Message-ID: <20210723084459.GA21470@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kili (102.222.70.252) by ZRAP278CA0015.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend Transport; Fri, 23 Jul 2021 08:45:09 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bab0e806-7f01-49a8-9eae-08d94db62f10
X-MS-TrafficTypeDiagnostic: MWHPR10MB1376:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR10MB13762E7EC7C6D33B05E9D2808EE59@MWHPR10MB1376.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 26v/vXj10Ob1utaih22BT6kIsFDxh0944Qr9Uuj7MCryIrTDkExSzhv8L6mb/glE8ky1rwfcaIHE56T0d1UsVNV72NJVjgHwwPj68jM2L4Ctpju75Ez4TyHRIzCksWLOApErKYcu3m30B3gyQ8U7GnlTUNpF9MrtvywS6P1lS9zpPre1PyxWWJ2NfyyxZsnu1voq8cTzSjLkG+eH+vQgGjCrvPgPdZrq5uItjlNvJzMk+IBOQsz8UIGXNEfvqSmrPZJGWuuj9+9C7O+oxW5GM6Wt6sSBEeB8iK2CJUbmNlY1494oFwkdPQbXv+Jzzx+75+LK9TUGvmjiK5LHLIMi942AWHx+DGKti477EdRS+qD0N3GQffEZzOKLHqwHVNf4WTiJHBDKKiqAn+p7tv9G2Xo7c4I7pQwPo82BQfHFGW3VxbCbMMeW7/eduz+ymA+6RP1eP5njhwh5Hy7Ay5in+wmCCrjdebJ0dGve8gXhu88sVU76/ylX2N3NKFNZbARYQkSXzB+p8hCXie3IQ/G/QyJ3dIIpCYds1ipWH3Ip9+AVJa0p+xSHkhewMBxWdWHIGYmthVK4LZ/rmfx02kqjac9V2v/R/J6VMsvZfH9VWeaoEKL9QtM7FP1hWymj2z0fPWvzZ4Q4Xb8yIR3bFANZkruuEV3/+3s2TqL/A8uZe6P36LV316Yq00dzHIt+f6Ahpn37ymgAXvS97V5D3oiHBQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(376002)(136003)(366004)(39860400002)(956004)(86362001)(9576002)(8936002)(8676002)(186003)(5660300002)(4744005)(33656002)(478600001)(66476007)(66946007)(66556008)(26005)(2906002)(1076003)(44832011)(9686003)(55016002)(83380400001)(38100700002)(38350700002)(4326008)(33716001)(6666004)(52116002)(6916009)(316002)(6496006);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HAhs0DvIJnMlNO1M14x78AAFkGJgVTFlVJ1jP1/B03L8GWkVkdQmtjSxVQ3J?=
 =?us-ascii?Q?wNB4lXYMMlcUL+tccuDm2nNNNu3oG0VlerDLfqmz2dhy/SKoDBV67vLtuVh1?=
 =?us-ascii?Q?sN4dotg7ZebQWIY0ytXMpPzOkDkJwf0gACxex0Ssjq7KVojxQUWgOjcZ3VkQ?=
 =?us-ascii?Q?IkqGMsZAKJVLCKmNW420XifMm7uPXBKaWpbFBvvOEur7fPAwqMm57u8TJ3VS?=
 =?us-ascii?Q?Jde3HXkJ+B1M1fTsHOqKDUnmi2YgK2lsFAhYN9hQ7Andp6wOc0GuGTC/MW7c?=
 =?us-ascii?Q?xUXTJP5Oquuhn0FlvwOSIKhDKAKezIRnXWUNZqAu4pGgVbBvUbhta6vn4IvK?=
 =?us-ascii?Q?UXxSCsqSVhHr6Pgn/1eVmu4dpNN4D3ROVNCc6prUsWnfPCsHJIvKft1eFl7a?=
 =?us-ascii?Q?KtxH8lM2CfBO5wh/cWIH+S8cZ0QSdrcvySOw0ymYY+eNX3DhCMlqtntMzIIc?=
 =?us-ascii?Q?QdSADci35+qB5atSRvRsAkz35ZXe26Te2tnrO4DnahT77MKIxhSh/zmudJXh?=
 =?us-ascii?Q?pe0wZpQyl3ixwL45Cks8CMpsgeIjc3TWcxg5xoJ70XMNUyJ8uZC8+ybj6pwH?=
 =?us-ascii?Q?Lkk1U6ykwJHu1R57oJxz9e9NQBR57NA8s7UMuIJIvXPck+bOjMczDIpRxxXd?=
 =?us-ascii?Q?g3TgG+xiejFuZJ52ufqAXffYMTxxd7viJ9NdER8SO0VvMqvP10Sg1u/PdZyR?=
 =?us-ascii?Q?LdcEJfJJSKsNYmblEnFMz2ju+fW+je5RDRTQb2IBuauX6E2gjRuFOnbUItJM?=
 =?us-ascii?Q?q/rkPjYpJZICGlwNmc12BOrcqjpulQVstj10xzBjINbz9PuvaNB94UGI9+9k?=
 =?us-ascii?Q?YxDifr0T5OVEPFC+hsJzLu1g4X7HRZlqixXGBD8ZTpmTO26GiiCjlWvpmWME?=
 =?us-ascii?Q?T97tY1QLCCT0WgtFKfz1qOHnZUgcIrvEbI5RP4BWMGj78x3VENSTOzUhaUQt?=
 =?us-ascii?Q?YQHRXfGB2zdOjNI1/bvxuw0qR+InsMVBFGiRISsq6AebN5TmWp8nha72KvaU?=
 =?us-ascii?Q?RMedg/4VPA81USQqP37M9+OYkXZY2iwexpPojDtijhnKONBXX0DHsX9VR3rT?=
 =?us-ascii?Q?bB5ZmKu72aZKVtAof0B8F3VsvhbxTqm/kxpk209uWP6G+bVhTlRQMsW4M30i?=
 =?us-ascii?Q?jDOOavshQF4LC88HjmoD7gmxwHaZdFVNiOtV5vY5MTuZIBPhw6taurwiqKkb?=
 =?us-ascii?Q?Nj+veO/p86ummYIa7Bg8QR07YJQXjQhBc6AXjZEQrURYawIThlWBUkM0rKSe?=
 =?us-ascii?Q?Fqv7gS6G42VcA2Oqvoa99+fIBAacZw4GbzITGhCweWXYI99FuajnrFZTCuxY?=
 =?us-ascii?Q?9//+sc/x6FliAQSCrvJgZ/UN?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bab0e806-7f01-49a8-9eae-08d94db62f10
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2021 08:45:12.0359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RuezqrnqjCIEGGa+Vjji9F2wc0a+jfD3WNqflEpwLAgQDzgs/pY6SHq3rPMC/1vlDNNvN6spJMf0gcNJ2IhnGGYrSNd43HFDLTVy+96u5z8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1376
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10053 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0
 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107230049
X-Proofpoint-ORIG-GUID: Se95rxn7-is9c2yWQ_yQ6J4tv-a-LanK
X-Proofpoint-GUID: Se95rxn7-is9c2yWQ_yQ6J4tv-a-LanK
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The copy_from_user() function returns the number of bytes remaining to
be copied but we should return -EFAULT here.

Fixes: 007888f365c9 ("ipmi: ssif_bmc: Add SSIF BMC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/char/ipmi/ssif_bmc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
index b15c05622e72..ce8cd8364a3f 100644
--- a/drivers/char/ipmi/ssif_bmc.c
+++ b/drivers/char/ipmi/ssif_bmc.c
@@ -85,9 +85,8 @@ static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_t
 	if (count > sizeof(struct ssif_msg))
 		return -EINVAL;
 
-	ret = copy_from_user(&msg, buf, count);
-	if (ret)
-		return ret;
+	if (copy_from_user(&msg, buf, count))
+		return -EFAULT;
 
 	if (!msg.len || count < ssif_msg_len(&msg))
 		return -EINVAL;
-- 
2.20.1