Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Jul 2021 11:02:00 +0200
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Michel =?iso-8859-1?Q?D=E4nzer?= <michel@daenzer.net>
Cc:     Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] dma-buf/poll: Get a file reference for outstanding fence
 callbacks
Message-ID: <YPqFiPftjTUV4361@phenom.ffwll.local>
Mail-Followup-To: Michel =?iso-8859-1?Q?D=E4nzer?= <michel@daenzer.net>,
        Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
References: <20210723075857.4065-1-michel@daenzer.net>
 <f5f37693-bfe2-e52f-172b-00f4aa94dbd9@amd.com>
 <4cf94f59-f953-f5d7-9901-cfe5fd63bfbc@daenzer.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4cf94f59-f953-f5d7-9901-cfe5fd63bfbc@daenzer.net>
Precedence: bulk

On Fri, Jul 23, 2021 at 10:19:49AM +0200, Michel D?nzer wrote:
> On 2021-07-23 10:04 a.m., Christian K?nig wrote:
> > Am 23.07.21 um 09:58 schrieb Michel D?nzer:
> >> From: Michel D?nzer <mdaenzer@redhat.com>
> >>
> >> This makes sure we don't hit the
> >>
> >> ????BUG_ON(dmabuf->cb_in.active || dmabuf->cb_out.active);
> >>
> >> in dma_buf_release, which could be triggered by user space closing the
> >> dma-buf file description while there are outstanding fence callbacks
> >> from dma_buf_poll.
> > 
> > I was also wondering the same thing while working on this, but then thought that the poll interface would take care of this.
> 
> I was able to hit the BUG_ON with https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1880 .

igt test would be really lovely. Maybe base something off the
import/export igts from Jason?
-Daniel

> 
> 
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Michel D?nzer <mdaenzer@redhat.com>
> >> ---
> >> ? drivers/dma-buf/dma-buf.c | 18 ++++++++++++------
> >> ? 1 file changed, 12 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> >> index 6c520c9bd93c..ec25498a971f 100644
> >> --- a/drivers/dma-buf/dma-buf.c
> >> +++ b/drivers/dma-buf/dma-buf.c
> >> @@ -65,12 +65,9 @@ static void dma_buf_release(struct dentry *dentry)
> >> ????? BUG_ON(dmabuf->vmapping_counter);
> >> ? ????? /*
> >> -???? * Any fences that a dma-buf poll can wait on should be signaled
> >> -???? * before releasing dma-buf. This is the responsibility of each
> >> -???? * driver that uses the reservation objects.
> >> -???? *
> >> -???? * If you hit this BUG() it means someone dropped their ref to the
> >> -???? * dma-buf while still having pending operation to the buffer.
> >> +???? * If you hit this BUG() it could mean:
> >> +???? * * There's a file reference imbalance in dma_buf_poll / dma_buf_poll_cb or somewhere else
> >> +???? * * dmabuf->cb_in/out.active are non-0 despite no pending fence callback
> >> ?????? */
> >> ????? BUG_ON(dmabuf->cb_in.active || dmabuf->cb_out.active);
> >> ? @@ -196,6 +193,7 @@ static loff_t dma_buf_llseek(struct file *file, loff_t offset, int whence)
> >> ? static void dma_buf_poll_cb(struct dma_fence *fence, struct dma_fence_cb *cb)
> >> ? {
> >> ????? struct dma_buf_poll_cb_t *dcb = (struct dma_buf_poll_cb_t *)cb;
> >> +??? struct dma_buf *dmabuf = container_of(dcb->poll, struct dma_buf, poll);
> >> ????? unsigned long flags;
> >> ? ????? spin_lock_irqsave(&dcb->poll->lock, flags);
> >> @@ -203,6 +201,8 @@ static void dma_buf_poll_cb(struct dma_fence *fence, struct dma_fence_cb *cb)
> >> ????? dcb->active = 0;
> >> ????? spin_unlock_irqrestore(&dcb->poll->lock, flags);
> >> ????? dma_fence_put(fence);
> >> +??? /* Paired with get_file in dma_buf_poll */
> >> +??? fput(dmabuf->file);
> > 
> > Is calling fput() in interrupt context ok? IIRC that could potentially sleep.
> 
> Looks fine AFAICT: It has
> 
> 		if (likely(!in_interrupt() && !(task->flags & PF_KTHREAD))) {
> 
> and as a fallback for that, it adds the file to a lock-less delayed_fput_list which is processed by a workqueue.
> 
> 
> -- 
> Earthling Michel D?nzer               |               https://redhat.com
> Libre software enthusiast             |             Mesa and X developer

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch