Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] gpu: host1x: select CONFIG_SYNC_FILE
From:   Mikko Perttunen <cyndis@kapsi.fi>
To:     Arnd Bergmann <arnd@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Mikko Perttunen <mperttunen@nvidia.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, dri-devel@lists.freedesktop.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210723091424.1682193-1-arnd@kernel.org>
 <0f4d1f0a-c313-a60e-6a72-fd4b0c757bc3@kapsi.fi>
Message-ID: <b7432d28-1082-1500-b4bd-fa566c63d264@kapsi.fi>
Date:   Fri, 23 Jul 2021 12:18:53 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <0f4d1f0a-c313-a60e-6a72-fd4b0c757bc3@kapsi.fi>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/23/21 12:17 PM, Mikko Perttunen wrote:
> Hi Arnd,
> 
> I think the best fix for this is to just remove that function -- it is 
> currently not used anywhere. I posted a patch to do that, but Thierry is 
> currently on vacation so it hasn't been picked up yet.

.. and sorry for the top post ..

Mikko

> 
> thanks,
> Mikko
> 
> On 7/23/21 12:14 PM, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> With the addition of the DMA fence, the host1x driver now fails to
>> build without the sync_file helper:
>>
>> arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function 
>> `host1x_fence_create_fd':
>> fence.c:(.text+0x624): undefined reference to `sync_file_create'
>>
>> Fixes: ad0529424def ("gpu: host1x: Add DMA fence implementation")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>   drivers/gpu/host1x/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
>> index 6dab94adf25e..6f7ea1720a39 100644
>> --- a/drivers/gpu/host1x/Kconfig
>> +++ b/drivers/gpu/host1x/Kconfig
>> @@ -3,6 +3,7 @@ config TEGRA_HOST1X
>>       tristate "NVIDIA Tegra host1x driver"
>>       depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>>       select IOMMU_IOVA
>> +    select SYNC_FILE
>>       help
>>         Driver for the NVIDIA Tegra host1x hardware.
>>