Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ZKifuDv9UDaj/i94yCZyINC0CKXsnJCFTp42ZmY/1C1Py+oa0glJ4hjaOdIp+QFqu+zZe+U1Nk
 BfvHqUj/ekQs810CSRcHptTpmgL/PmbZBouE/DwwtjACKOEDWncaAsXQVbjHWmXI9Q2m8Tex/H
 L8RLaVRH3oHIZgY3PFLWr4tpIHJZkNGEn4VOTgHlZaeIw5lQzo8GTvgzKSwBU1otFosSkMdLv/
 N15Q8TuAR/Yrmgq4wIEdBxEOPRuEde4OGga72+p9Zny/2kkPc37XARh5hQXRQTF59LzH8oIMt2
 4Jqj41WCGltBulQGmgds8zPr
IronPort-PHdr: A9a23:SpzcixGPMlQblJjUnidz551GfzBMhN3EVzX9CrIZgr5DOp6u447ld
 BSGo6k31BmSAs6Cs6gMotGVmpioYXYH75eFvSJKW713fDhBt/8rmRc9CtWOE0zxIa2iRSU7G
 MNfSA0tpCnjYgBaF8nkelLdvGC54yIMFRXjLwp1Ifn+FpLPg8it2O2+5YHfbx9GiTe/br9+M
 Qm6oRvMvcQKnIVuLbo8xAHUqXVSYeRWwm1oJVOXnxni48q74YBu/SdNtf8/7sBMSar1cbg2Q
 rxeFzQmLns65Nb3uhnZTAuA/WUTX2MLmRdVGQfF7RX6XpDssivms+d2xSeXMdHqQb0yRD+v9
 LlgRgP2hygbNj456GDXhdJ2jKJHuxKquhhzz5fJbI2JKPZye6XQds4YS2VcRMZcTyNOAo2+Y
 IUPAeQPPvtWoZfhqFYVsRuyGROhCP/zxjNUhHL727Ax3eQ7EQHB2QwtB9ABsHXVrdX1KacSV
 v2+w6rIzTrZbvNdxDDw6YjJcxAhu/6MXK58fdbfxEQ0CgPKkk+QpZb7MDyIy+QAqm6W5PdvW
 uyzkWAosR1xoiSxycc2jInEno0Yx1TA+Ch5zog5O9K1RUp0b9OnH5ZduSGXOoVqT84jX2xlu
 Sg3x74btZOmYSQHy4oqyhDQZvGEboWG7A/uWfqXLDxlh3xlYKqyiwiu/UWk0OHxVcm53ExUo
 iZYk9TArHIA2wDV58OaUPVy5F2h1iyK1w3L7+FEJl07mrTDJp46x74wioITsUPeHi/qgEn2j
 LGZdkEj+uWw7uToeLTmppuFO49siAHyL70imsK9DOgkKAQOUG+b+eOz1L3n40L1WqlFjvozk
 qXBsZDaI9oUprKhDgNLzoou7wyzAjSm3dgCg3ULMVNIdAiFgoT1I13OJer3Dfa7g1Siijdrw
 PXGM6XhA5TMLnjMirbhcaph50NS0wcz0MxQ54hOBr4fPf3zR1f9tMbEAR8hLwy03+HnBc151
 oMfX2KPH6CYPLrRsVCW/OIvJfeDZIsOtTbjJPgq+eTugWU6mVADZ6mp24UYaHSiEvRhOUWZb
 imkvtBUPW4M9iE3VvTnjkGPS3YHa3+0Gak1/Ck2Dp6rF6/EXImmhLHH1yC+SM54fGdDX2GNA
 3f1cM22W/4NIHaDMM9ok2RcDpC8QJVn2B2z4lypg4F7J/bZr3VL/ano08J4sqiKzUlayA==
IronPort-HdrOrdr: A9a23:3/vxm6q5gG1hQqC4jrec9z4aV5oQeYIsimQD101hICG9vPbo7v
 xG/c5rrSMc5wxhPU3I9erwWpVoBEmslqKdgrNxAV7BZniDhILAFugLhrcKgQeBJ8SUzJ876U
 4PSdkZNDQyNzVHZATBijVQ3+xO/DBPyszHudvj
MIME-Version: 1.0
References: <20210723085145.1ce7ee5c@canb.auug.org.au> <20210723003607.64179-1-yzhai003@ucr.edu>
 <20210723081034.GD1931@kadam>
In-Reply-To: <20210723081034.GD1931@kadam>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Fri, 23 Jul 2021 02:19:08 -0700
Message-ID: <CABvMjLQ5PW+cddeYCgiR4xx9dKWVdKsaJLrUYFPMmsOLk+a1HA@mail.gmail.com>
Subject: Re: [PATCH v4] media: atomisp: fix the uninitialized use and rename "retvalue"
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Juan Antonio Aldea-Armenteros <juant.aldea@gmail.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Dan:
I updated the fix tag in this version, I would sign the patch using my
full name, thanks.

On Fri, Jul 23, 2021 at 1:11 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Fri, Jul 23, 2021 at 12:36:04AM +0000, Yizhuo wrote:
> > Inside function mt9m114_detect(), variable "retvalue" could
> > be uninitialized if mt9m114_read_reg() returns error, however, it
> > is used in the later if statement, which is potentially unsafe.
> >
> > The local variable "retvalue" is renamed to "model" to avoid
> > confusion.
> >
> > Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
> > Signed-off-by: Yizhuo <yzhai003@ucr.edu>
> > ---
>
> Is your full name just Yizhuo or Yizhuo Zhai?  Please use your legal
> name as if you were signing a legal document.
>
> I don't think you have changed anything in this version?  It's basically
> a resend of the patch from Jun 25?  Please put that information under
> the --- cut off.
>
> Looks okay to me.
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside