Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1239589pxv; Fri, 23 Jul 2021 03:32:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/r4qpqSl4qfoVKDkBYDddNDOjS4hQ9cjVUFuigkMLKn7nEurTfcIscWUmy4OIOO91ki0f X-Received: by 2002:a05:6402:752:: with SMTP id p18mr4772077edy.281.1627036367958; Fri, 23 Jul 2021 03:32:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627036367; cv=none; d=google.com; s=arc-20160816; b=kMkHdH/okADo/5/Rv0a9pDa/HLvAvJsUfz0ddCx4f6aPufcKQsTFWFyXr8KhuwWIjY W5qki3TpKtYqpgrN2x4LOe3wA6NCAFwH4mSU7WyCBBx6c/fw3LC1HxPIHMk2r492B8GC eKZ8gZw+P4UOkX63/zAR4Sj8O4r6BgVc21rITeGFwi8QVmMfkpYzjBbDncDWeTjG2ETl EH7+XIRvgtJMIDr7PImbUvJjbKfRV6p7LWKQEyWW683JUIblWfP/q4++ebS/+xSVEgB/ 4tkesAaJluIddqk+32MJ2aBCmo2hvOEzbyydkhTtkIsTjmfV3aI86p3+PA0SOyWeL1tI BrEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=eCTcORAv1g4ZQcCl45BbfbmRXduUC1LuQuWshBTXAcU=; b=UTVim4UFfaQDWK1QVJy9Wh1J3ZpEumu6U77CDu7yK2b9QsVqXHIbUDzWWdfXXfVefZ buzsPC++r0YZK9ZYLPsLoxeA56BMkgevkIAptweIf0bZFhVePPkvsxcHC8n3QhObbcK/ 2nalzCaJvt697BqJ6S1THidKTYvLWJsD8NzYvnu25+F29jqBLC7UM7HMMWtWnf/MFGjU 1GM5EBucdZbEJERUWO4DnZ7mFtD5a95Rm2DRQH4dG+yQ4Lie1lK73KsLdG24HN5byqsm 6VzXbscx9g0IMEq3nKK1GCfZjBm4IAo312TMGQ2evc0z2hGVYA/sL3tqiRcg0KmYtK5+ l5/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QpURZJKe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nc23si34174449ejc.83.2021.07.23.03.32.22; Fri, 23 Jul 2021 03:32:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QpURZJKe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231710AbhGWJuF (ORCPT + 99 others); Fri, 23 Jul 2021 05:50:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230420AbhGWJtr (ORCPT ); Fri, 23 Jul 2021 05:49:47 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F68DC061575; Fri, 23 Jul 2021 03:30:20 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id b7so1163893edu.3; Fri, 23 Jul 2021 03:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eCTcORAv1g4ZQcCl45BbfbmRXduUC1LuQuWshBTXAcU=; b=QpURZJKeVutsL2qJCbTXmluDt838EfpKWZvDZVTk/VltnTaXidaJZ/FAEi8B33O8TY I2wTTYGIcQ80aCU49Xqu982fgV/ActDLwyeSGS7G1NXGmeKUtCtJxr9LMDp34R0rHjyy HUfI4i8yeuJ3mEfcB2x1ecWDHfKySTGkI3S/PbjUYAd1CwW/CCk8YDAvUB6ZNG/qqmxs RTT63hyrxitUbdwHXfmRCPWzlEzpspfDIB0SR7cJjWAsKoTir8XbMT1odgjMepzl/clm 6Gp+PrHmnSRQKt35syaxFWK40NSXj1Mf/GNL9Y7AT51zq+Boi6rNKCEuyBHxzr+0ZGKy RG6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eCTcORAv1g4ZQcCl45BbfbmRXduUC1LuQuWshBTXAcU=; b=G0Uu/VNWaIv7YK4lEl8fNkLXQ11enX/0jjWzpPeOvsnQ+DZM5efClyYCLk3cqo46dj CTfMR6VNph5kZaE7uD/jr0SF3aQ/84Anemo+C78mjjOaaDWiE/LMMFKrNItpxCzuoZXb OTUktvOn2RRpRa9NxZwLavAR8k3T38pDSCSvcjWGFDrm2hBLI4XF43FabfrDi66whbiX lvTwfkOoBQW+5gbk8RsqPGGDOzf62KIHVZCXXrPt0zwCs+gnayUBNQoITE+g7ZA41053 qZREsbo3XMEtWvNz+JF6qmWr/4+E/wV1re/QmHN0erhs4bp2JvSeficd+H8nmfGomiYn Gt7g== X-Gm-Message-State: AOAM533NHaarKmzh6oxALNdMktRQfqi7vRxf3OfhIBTQxrQ6LCg37KjM NWarQxaWHZ+sYJo5ceHIA2pq7HGlmyq7wg15zfY= X-Received: by 2002:a05:6402:18c4:: with SMTP id x4mr4770170edy.350.1627036219141; Fri, 23 Jul 2021 03:30:19 -0700 (PDT) MIME-Version: 1.0 References: <20210723074317.32690-1-jslaby@suse.cz> <20210723074317.32690-5-jslaby@suse.cz> In-Reply-To: <20210723074317.32690-5-jslaby@suse.cz> From: Max Filippov Date: Fri, 23 Jul 2021 03:30:07 -0700 Message-ID: Subject: Re: [PATCH 4/8] tty: stop using alloc_tty_driver To: Jiri Slaby Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, LKML , Richard Henderson , Ivan Kokshaysky , Matt Turner , Geert Uytterhoeven , "James E.J. Bottomley" , Helge Deller , Jeff Dike , Richard Weinberger , Anton Ivanov , Chris Zankel , Samuel Iglesias Gonsalvez , Jens Taprogge , Karsten Keil , Ulf Hansson , "David S. Miller" , Jakub Kicinski , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Laurentiu Tudor , Jiri Kosina , David Sterba , Shawn Guo , Sascha Hauer , Oliver Neukum , Felipe Balbi , Johan Hovold , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 23, 2021 at 12:43 AM Jiri Slaby wrote: > > alloc_tty_driver was deprecated by tty_alloc_driver in commit > 7f0bc6a68ed9 (TTY: pass flags to alloc_tty_driver) in 2012. > > I never got into eliminating alloc_tty_driver until now. So we still > have two functions for allocating drivers which might be confusing. So > get rid of alloc_tty_driver uses to eliminate it for good in the next > patch. > > Note we need to switch return value checking as tty_alloc_driver uses > ERR_PTR. And flags are now a parameter of tty_alloc_driver. > > Signed-off-by: Jiri Slaby > arch/xtensa/platforms/iss/console.c | 7 +++---- Acked-by: Max Filippov -- Thanks. -- Max