Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1244757pxv; Fri, 23 Jul 2021 03:40:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCGDt1KnHCJQZ/PEBCZv7sRlXtQYV4WIuVhsyznns4369imYN9sXL+1uh9s0bIZPpXqkq6 X-Received: by 2002:a50:ee87:: with SMTP id f7mr4713384edr.155.1627036821513; Fri, 23 Jul 2021 03:40:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627036821; cv=none; d=google.com; s=arc-20160816; b=pMTUPOq2/c6lEOsL2pkSLojYx7uZNeHzFoRAS9wc/1Z4MAMFef2YAKkWDPhI6soXEe Uks+3TfJi2HrKAMhaKEjlKLZzNu9OPsP4qUJWAfa/6nsGMicTjgAldVL8GiVWH2/KJPc lInlnXz9ReqKngtuRyIGwEkjzC2oIQCeCut1e0KbUbHjBG76Nrn6mo7CbRp9kSdX5vaJ jUOyM71RoilO5broDvF/x0Pqb5+XbiAsUCK69huYuEGTAWdyK4UG3ls3JeCe0lzReQGB KaY8GFHYEzHmj6ejxiPE2bW2Jbp9LK3xZJ4vNmIVF5CyB0/zOD5yfrDZxTIQejXqZq03 R61A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=8pWrISRn6yZEDCi6Q7lxa04a/P6MxgUSq5UxHEjQS/4=; b=m6knRCDeK+CpOk4KgLVX4V8BY0SzVDHYd5V7puiVksU2OTgjc6CnDT96JA2bT/oHeL eekM7QyvAvbZqjD7cTg8xUBdK4sBdBSaCYG0QKaeQ37DD/5PJY+TCcbH0JL2dKXEwqph mhhX9Rcu+6sVYrfImiR/eUzrBquhZNCWDshn5FrvCf/XOK9ySp5i0X85VYkF6wXTAD83 JvJqhQWrNsOGne/vuwHp9hZKYL3Ua/AUBEchtfhP43W63B62EXslMCe090TaUoNUIDG+ +HfD/0Kz/4UOZ2tkzkZhGO86NtmeraUQn1ghHv5XoEC2Y0WTnK+X9Cvkx01lQ23BbtoO DqVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g20si34433913edw.5.2021.07.23.03.39.57; Fri, 23 Jul 2021 03:40:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231825AbhGWJzq (ORCPT + 99 others); Fri, 23 Jul 2021 05:55:46 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:32816 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231519AbhGWJzp (ORCPT ); Fri, 23 Jul 2021 05:55:45 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R701e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UgiGgeH_1627036571; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UgiGgeH_1627036571) by smtp.aliyun-inc.com(127.0.0.1); Fri, 23 Jul 2021 18:36:17 +0800 From: Jiapeng Chong To: tariqt@nvidia.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] mlx4: Fix missing error code in mlx4_load_one() Date: Fri, 23 Jul 2021 18:36:09 +0800 Message-Id: <1627036569-71880-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'err'. Eliminate the follow smatch warning: drivers/net/ethernet/mellanox/mlx4/main.c:3538 mlx4_load_one() warn: missing error code 'err'. Reported-by: Abaci Robot Fixes: 7ae0e400cd93 ("net/mlx4_core: Flexible (asymmetric) allocation of EQs and MSI-X vectors for PF/VFs") Signed-off-by: Jiapeng Chong --- drivers/net/ethernet/mellanox/mlx4/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index 00c8465..28ac469 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -3535,6 +3535,7 @@ static int mlx4_load_one(struct pci_dev *pdev, int pci_dev_data, if (!SRIOV_VALID_STATE(dev->flags)) { mlx4_err(dev, "Invalid SRIOV state\n"); + err = -EINVAL; goto err_close; } } -- 1.8.3.1