Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1] perf pmu: Add PMU alias support
To:     "Jin, Yao" <yao.jin@linux.intel.com>, <acme@kernel.org>,
        <jolsa@kernel.org>, <peterz@infradead.org>, <mingo@redhat.com>,
        <alexander.shishkin@linux.intel.com>
CC:     <Linux-kernel@vger.kernel.org>, <linux-perf-users@vger.kernel.org>,
        <ak@linux.intel.com>, <kan.liang@intel.com>, <yao.jin@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>
References: <20210722014546.11948-1-yao.jin@linux.intel.com>
 <ef8cc210-1a0a-796c-effa-63af590d17aa@huawei.com>
 <6b9fb1dc-5f53-d378-9119-84e991a0c86e@linux.intel.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <bf81673d-4b8f-e68a-bb44-32ad15b106f7@huawei.com>
Date:   Fri, 23 Jul 2021 12:46:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <6b9fb1dc-5f53-d378-9119-84e991a0c86e@linux.intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 23/07/2021 07:56, Jin, Yao wrote:
>>>
>>> Use the real name,
>>>   $ perf stat -e uncore_cha_2/event=1/ -x,
>>>     4044879584,,uncore_cha_2/event=1/,2528059205,100.00,,
>>>
>>> Use the alias,
>>>   $ perf stat -e uncore_type_0_2/event=1/ -x,
>>>     3659675336,,uncore_type_0_2/event=1/,2287306455,100.00,,
>>
>> Having a self-test case would be nice. And it's questionable why this 
>> goes in x86 code.
>>
> 
> OK, I will add test cases for uncore PMU alias.
> 

JFYI, I am doing a bit of a rewrite of tests/pmu-events.c to tighten it 
up to catch cases like those fixed and also broke in "perf tools: Fix 
pattern matching for same substring in different pmu type".

> For why it's now only x86 specific code, my understanding is, currently 
> x86 has this usage case, we can further extend it to other ARCHs and 
> make it a generic way in future.

Generally that is not how things are done, but I'm not the maintainer ...

Thanks,
john