Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Jul 2021 15:28:40 +0300
From:   "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>
To:     Dennis Giaya <dgiaya@whoi.edu>
Cc:     "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: max310x: Use clock-names property
 matching to recognize XTAL
Message-ID: <YPq1+NzJeqLZVctW@smile.fi.intel.com>
References: <20210722150233.30897-1-andriy.shevchenko@linux.intel.com>
 <YPmSpNZr/yQiPqsO@smile.fi.intel.com>
 <0acef8aa86d69cac0ea1a3dbdafc41625580e0eb.camel@whoi.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0acef8aa86d69cac0ea1a3dbdafc41625580e0eb.camel@whoi.edu>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Jul 22, 2021 at 09:05:13PM +0000, Dennis Giaya wrote:
> Andy,
> 
> I've tested this out on my hardware that uses an external oscillator
> 'osc' (as opposed to external crystal 'xtal').
> 
> With the relevant asl
> 	Package () {"compatible", "maxim,max14830"},
> 	Package ()
> {"clock-frequency", 19200000},
> 	Package () {"clock-names", "osc"},
> 
> Previously, the driver logic would default to 'xtal' and then compare
> against the narrower frequency range and throw an error because 19.2MHz
> was not allowed. With your patch, it proceeds as 'osc' and appears to
> work as intended.

Thanks for testing!
I assume I may convert above to the Tested-by: or equivalent tag.

JFYI, in OSS mailing lists we do not top post.


-- 
With Best Regards,
Andy Shevchenko