Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] device property: Check fwnode->secondary in
 fwnode_graph_get_next_endpoint()
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        rafael@kernel.org, laurent.pinchart@ideasonboard.com
References: <20210722201929.3585671-1-djrscally@gmail.com>
 <20210722201929.3585671-2-djrscally@gmail.com>
 <YPq28BNOmqZPdRqq@smile.fi.intel.com>
From:   Daniel Scally <djrscally@gmail.com>
Message-ID: <acf4838d-3c70-20c1-5fce-ee36765b06c4@gmail.com>
Date:   Fri, 23 Jul 2021 14:04:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YPq28BNOmqZPdRqq@smile.fi.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 23/07/2021 13:32, Andy Shevchenko wrote:
> On Thu, Jul 22, 2021 at 09:19:28PM +0100, Daniel Scally wrote:
>> Sensor drivers often check for an endpoint to make sure that they're
>> connected to a consuming device like a CIO2 during .probe(). Some of
>> those endpoints might be in the form of software_nodes assigned as
>> a secondary to the device's fwnode_handle. Account for this possibility
>> in fwnode_graph_get_next_endpoint() to avoid having to do it in the
>> sensor drivers themselves.
> ...
>
>> +	ep = fwnode_call_ptr_op(parent, graph_get_next_endpoint, prev);
>> +
>> +	if (IS_ERR_OR_NULL(ep) && !IS_ERR_OR_NULL(parent) &&
>> +	    !IS_ERR_OR_NULL(parent->secondary))
> Nit-pick, I would put it like:
>
> 	if (!IS_ERR_OR_NULL(parent->secondary) && !IS_ERR_OR_NULL(parent) &&
> 	    IS_ERR_OR_NULL(ep))
>
> or
>
> 	if (IS_ERR_OR_NULL(ep) &&
> 	    !IS_ERR_OR_NULL(parent->secondary) && !IS_ERR_OR_NULL(parent))
>
> for the sake of logical split.


OK; I'll do the second one, feel like it's better to have ep as the
first check.

>
>> +		ep = fwnode_graph_get_next_endpoint(parent->secondary, NULL);