Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Jul 2021 15:00:39 +0100
From:   Mark Brown <broonie@kernel.org>
To:     "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc:     "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
        "markpearson@lenovo.com" <markpearson@lenovo.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] ASoC: amd: Don't show messages about deferred
 probing by default
Message-ID: <20210723140039.GD5221@sirena.org.uk>
References: <20210722132731.13264-1-mario.limonciello@amd.com>
 <20210723123847.GB5221@sirena.org.uk>
 <SA0PR12MB45103F60E23D6BE8CF7E603DE2E59@SA0PR12MB4510.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="1sNVjLsmu1MXqwQ/"
Content-Disposition: inline
In-Reply-To: <SA0PR12MB45103F60E23D6BE8CF7E603DE2E59@SA0PR12MB4510.namprd12.prod.outlook.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--1sNVjLsmu1MXqwQ/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 23, 2021 at 01:04:51PM +0000, Limonciello, Mario wrote:
> > On Thu, Jul 22, 2021 at 08:27:27AM -0500, Mario Limonciello wrote:

> > > This isn't useful to a user, especially as probing will run again.
> > > Use the dev_err_probe helper to hide the deferrerd probing messages.

> > The reason we have these error messages is that they are very useful to
> > users if they ever find that the device isn't instantiating due to some
> > missing dependency or something that leaves it stuck in probe deferral,
> > they give some hint as to what might be wrong.

> Right, but they should be at debugging level, if someone has a problem they
> turn on dynamic debugging for the module and then can see these messages.

Your commit message says that reporting the error isn't useful, I am
flagging that it is useful to have the messages be available to people.

--1sNVjLsmu1MXqwQ/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmD6y4cACgkQJNaLcl1U
h9Dl7gf9EwtHg6Jq5Oc8xZqGS3b1Kfc+fqNmXfpv1/0NXIKa/hOJ0hBu66ssoBeE
Y6RRvEmsMMjYgyAavhPkm8fhBy9KopJkVpKx1rHoei6R4nGuxHDijT4baC6dOT9n
GKUioqcKo+E5b8zZ+CBv+pkaejDu138/RBRnjNepjwtaaRa2m5xmV7St0lyCzvnG
cuogRLKm3m65SphnfPZz3CO4TdqwtibbNUjkFbJYhmhDMoirJz2tuOO+66R+fL9c
GC5tPK4NB5JO3tu0I/ZCUwxNAe4IScjsSv3DC0q6ZR+fBsQhyDJgeXNRppvwXPG/
J+AvvEmddNGms2U09LSSWGnevgpF6g==
=h35f
-----END PGP SIGNATURE-----

--1sNVjLsmu1MXqwQ/--