Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Jul 2021 16:30:25 +0200
From:   Len Baker <len.baker@gmx.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Len Baker <len.baker@gmx.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/ks7010: Remove all strcpy() uses in favor of
 strscpy()
Message-ID: <20210723143025.GA2612@titan>
References: <20210717153759.13468-1-len.baker@gmx.com>
 <20210719052623.GW25548@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210719052623.GW25548@kadam>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Mon, Jul 19, 2021 at 08:26:23AM +0300, Dan Carpenter wrote:
> On Sat, Jul 17, 2021 at 05:37:59PM +0200, Len Baker wrote:
> > @@ -1808,7 +1808,7 @@ static int ks_wlan_get_firmware_version(struct n=
et_device *dev,
> >  {
> >  	struct ks_wlan_private *priv =3D netdev_priv(dev);
> >
> > -	strcpy(extra, priv->firmware_version);
> > +	strscpy(extra, priv->firmware_version, sizeof(extra));
>
> Extra is a pointer and not an array so this doesn't work.

Apologies. I will send a v2 for review.

Thanks for your time.
Len