Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     Arnd Bergmann <arnd@kernel.org>, Ingo Molnar <mingo@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smpboot: remove duplicate inline keyword
In-Reply-To: <20210723091618.1750551-1-arnd@kernel.org>
References: <20210723091618.1750551-1-arnd@kernel.org>
Date:   Fri, 23 Jul 2021 16:27:01 +0100
Message-ID: <8735s5m4oq.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Hi,

On 23/07/21 11:16, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> 'static inline void __always_inline' is one more 'inline' than needed,
> and it's in the wrong place as gcc points out when extra warnings
> are enabled:
>
> kernel/smpboot.c:50:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
>    50 | static inline void __always_inline idle_init(unsigned int cpu)
>
> Move it to the right place instead.
>
> Fixes: e9ba16e68cce ("smpboot: Mark idle_init() as __always_inlined to work around aggressive compiler un-inlining")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Colin sent a similar fix at:

  http://lore.kernel.org/r/20210715164018.62712-1-colin.king@canonical.com

Now AFAICT the incriminated patch is in tip/core/urgent and
linux-next/master, but not in the current mainline. If so, this could be
fixed up before it gets pulled.