Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Jul 2021 18:30:40 +0200
From:   Len Baker <len.baker@gmx.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Len Baker <len.baker@gmx.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nikolay Kyx <knv418@gmail.com>,
        Aditya Srivastava <yashsri421@gmail.com>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        William Durand <will+git@drnd.me>,
        Romain Perier <romain.perier@gmail.com>,
        Allen Pais <apais@linux.microsoft.com>,
        Phillip Potter <phil@philpotter.co.uk>,
        zhaoxiao <zhaoxiao@uniontech.com>, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/rtl8192e: Remove all strcpy() uses in favor of
 strscpy()
Message-ID: <20210723152559.GC2612@titan>
References: <20210718090636.7905-1-len.baker@gmx.com>
 <20210719054345.GO1931@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210719054345.GO1931@kadam>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Mon, Jul 19, 2021 at 08:43:45AM +0300, Dan Carpenter wrote:
> On Sun, Jul 18, 2021 at 11:06:36AM +0200, Len Baker wrote:
> > diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/st=
aging/rtl8192e/rtllib_softmac_wx.c
> > index f89799d43b1b..5968407c646d 100644
> > --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > @@ -543,7 +543,7 @@ int rtllib_wx_get_name(struct rtllib_device *ieee,
> >  			     struct iw_request_info *info,
> >  			     union iwreq_data *wrqu, char *extra)
> >  {
> > -	strcpy(wrqu->name, "802.11");
> > +	strscpy(wrqu->name, "802.11", sizeof(wrqu->name));
> >
> >  	if (ieee->modulation & RTLLIB_CCK_MODULATION)
> >  		strcat(wrqu->name, "b");
>
> This patch is just about silencing inferior static analysis tools,
> right?  Most checkers can figure out the size of the array and verify
> that it has space for "802.11".  Probably it's only raw grep which
> can't.
>
> It doesn't make sense to me that we have strscpy() followed by strcat.
> So let's fix both.

Ok, I will send a v2 for review. Thanks for the feedback.

>
> regards,
> dan carpenter

Regards,
Len