Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Jul 2021 17:29:02 +0100
From:   Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To:     Puranjay Mohan <puranjay12@gmail.com>
CC:     <Michael.Hennerich@analog.com>, <alexandru.ardelean@analog.com>,
        <jic23@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <lars@metafoo.de>, <Dragos.Bogdan@analog.com>,
        <Darius.Berghe@analog.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: accel: Add ADXL355 in
 trivial-devices
Message-ID: <20210723172902.00004151@Huawei.com>
In-Reply-To: <20210722062155.32998-2-puranjay12@gmail.com>
References: <20210722062155.32998-1-puranjay12@gmail.com>
        <20210722062155.32998-2-puranjay12@gmail.com>
Organization: Huawei Technologies Research and Development (UK) Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 22 Jul 2021 11:51:53 +0530
Puranjay Mohan <puranjay12@gmail.com> wrote:

> Add ADXL355, a 3-Axis MEMS Accelerometer into trivial-devices.yaml.
> 
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>

Hi Puranjay,

So, a binding should include (as well as we can) all hardware elements,
not just those currently supported by the driver.

This particular device has two interrupts + a dataready signal which is
effectively another interrupt. It also has dual power supplies.

That makes it a rather non-trivial device from the point of view of
bindings. Hence, please give it a file of it's own and also document
the interrupt and supply elements.

Jonathan
 
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 8341e9d23..0097d6e81 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -41,6 +41,8 @@ properties:
>            - adi,adp5589
>              # +/-1C TDM Extended Temp Range I.C
>            - adi,adt7461
> +            # ADXL355:- 3-Axis Low noise MEMS Accelerometer.
> +          - adi,adxl355
>              # +/-1C TDM Extended Temp Range I.C
>            - adt7461
>              # AMS iAQ-Core VOC Sensor