Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1579037pxv; Fri, 23 Jul 2021 11:43:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyik33RUJeOdxM6GAvKmdYGM/J/iIOI4l7rWSpyxWC/Ubc04sdoHsqvaycZOOF4+TxLqhlk X-Received: by 2002:a05:6e02:525:: with SMTP id h5mr4297757ils.205.1627065824232; Fri, 23 Jul 2021 11:43:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627065824; cv=none; d=google.com; s=arc-20160816; b=wnXpF5o0PIQPHdxdmMIBu0y6IWaKVxVD7JYwR/3/xkXeqx+gzJ6M27ZqNC4TUg840p 6F3MApTfQOBFkNJNH0kSHo18yMkQexA//XM78TnqdYtRiHeLd+H6mTjL3NXJd+aJNbSl rr769OjEI4WdM+WuJQtI+GfcaAMeGvFEF1USJBqy34bkA7aAhNn2kEleQOCUZR7IlIaS ORQPllzEM6Am8xe+M3Yk3ThzpBISsUxV2PMApQVHwQgaZfysOZdFerwqqhsppXp/XC07 nN+XIpaSI6ai2zW+WGcUm1WDViTm1OOustngKX8lrY5h7tTajBBMK7qGOhVC+krcjA4/ Njgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=RvxhWTwWVgMD4Z8Dsgp8iMNi4SBp/TjR0xJOl/T9cy0=; b=pV1yb34zuIf/yedQDfgVmvtOA3gIPv2ThPIRfSkj3NRpz3mwnyvit7qAM+yQwffK18 c6ZkC07BbVQkNJCquiX7aKahULGAFnZyq7w5eBcaPo/OPIVcpPFkJy5gH5dobxGf7v2L aQTszKukgUtf/Ef1hUHfo85unnAIHF20WYN8JTr6fIcPYVHiBDQ3528vm9zdJTQaLTbm y9i7adj0AxsQZd0V58phO7j1gqRDyjgNeV1LpCJwIRufPEkqznrItF+6bdEOadN/MtQK 07ndisX3lUillSxWqABT0hF57fAymrissnHmur5ByWFh7JzBmrzBz55GAQtVuaQkq59U S0/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=N83j4dx3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m4si35152014ioy.95.2021.07.23.11.43.15; Fri, 23 Jul 2021 11:43:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=N83j4dx3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbhGWSAF (ORCPT + 99 others); Fri, 23 Jul 2021 14:00:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:36042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbhGWSAE (ORCPT ); Fri, 23 Jul 2021 14:00:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DB85460F35 for ; Fri, 23 Jul 2021 18:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627065637; bh=luXtGcA9XPkn2pKeuXVILcPOHo+qWZTOu992ZyXafQg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=N83j4dx3rfgzlrRme4TcsorPA3CwCjlYZTPM33Jyuu5g1ZFvrbAHK2bAaJG+hdmG0 hw4wiFRurvy5qLdIXD/jJMuUTRK55/Zyq1SHsITZ1PxD/nANq7uea7MJeEe4jJGklt RScFbpJrFaNHDHSC0ibEy3+SX+3454CDR5eai2/u+EzZIZKAUyRrt/FWB+HWCSjBWR 3fNyj1im4apMuZSUXjAjCj0uGL3hPloYHnxqhVBBxc7UR21uRr9wy1tDCgeJAltvT0 oVvrJo3YOpzgXI2lpBpYGicBY+ir8bpx/qrVBXlHs3/VacQ/0dOuS+AFXQX5oBVVco GdQN4tYxbg/0g== Received: by mail-wr1-f51.google.com with SMTP id o1so3348299wrp.5 for ; Fri, 23 Jul 2021 11:40:37 -0700 (PDT) X-Gm-Message-State: AOAM531iy/wJ9TJUvl2ThBwZKX2ZlvaBp40387HAultsncqLpzgA31yR NKkJGA8bRkREwAaFChsVSz44ytrBPORQ36zBq7E= X-Received: by 2002:a5d:65cb:: with SMTP id e11mr6959840wrw.105.1627065636499; Fri, 23 Jul 2021 11:40:36 -0700 (PDT) MIME-Version: 1.0 References: <20210723091534.1730564-1-arnd@kernel.org> <7ddd0c7c-9bdc-9ea3-c635-f1d141d1e870@infradead.org> In-Reply-To: From: Arnd Bergmann Date: Fri, 23 Jul 2021 20:40:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n To: Karol Herbst Cc: Randy Dunlap , Ben Skeggs , David Airlie , Daniel Vetter , Lyude Paul , Arnd Bergmann , nouveau , LKML , dri-devel , Nikola Cornij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 23, 2021 at 6:34 PM Karol Herbst wrote: > On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote: > > On 7/23/21 8:15 AM, Karol Herbst wrote: > > > On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote: > > > > > > what's actually the use case of compiling with > > > CONFIG_DRM_NOUVEAU_BACKLIGHT=n anyway? > > > > Dunno. In this case it was just a randconfig. Still, it needs to be > > handled in some way - such as the other suggestion in this thread. > > > > sure, I was just curious if there was a specific use case or just > something random as you mentioned. I think this is purely done because of tradition. A long time ago, we had tiny framebuffer drivers and most PCs did not have backlights, so it made sense to leave this optional. This was probably just always carried over. Arnd