Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1582687pxv; Fri, 23 Jul 2021 11:50:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBh4I7YfzaBS3adWUYY22EiEqosQKnByEgi8edmjzT0Wv6SbotTvuKPTC24IDwzPnF2gco X-Received: by 2002:a05:6402:1c05:: with SMTP id ck5mr7337481edb.268.1627066250367; Fri, 23 Jul 2021 11:50:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627066250; cv=none; d=google.com; s=arc-20160816; b=aTkspsYNa20FeqCAychx94OTSh6j39NUcUqq2gr6oFjJjoW8p9qtLM163faC6padLk mowL2Q9cEfAIGS2nMyJvpTzXez/4cxUqSdKjqDxj+Mxk/YEmdkY3oEGM65J2ZaND6VQ+ k79HuIXXjfH/Y/eI5iPctIrLcdR99O90wASURVkWCGDnhhvHXV88ERl3bQVokHORyRTF w+KKi+TJohtIxQ2P/ksOj/38vvjvRjcPlibCUlVcio5jIa0m8n7GHcx5GAfXCaX9IePC 3fmWs2Z5TV52O03gXlnVGoXBseAed+sEKmO1Jp5ZAqR56yoVr8ov9DDr2ooylMWXTf+u jKTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=TT3QlzruQFM0O9S/g7+HR5WRHatrYiPktX1CpTRxfHI=; b=OLY4ZqYEaR+ZzHybLueTPI6QOIcMt9OyiJZnVfrXGVEIRGmstHbQjyyA7QeCX5FGpN rZoKeueiSwW2AFvfBsfFDQiUeJ+svcDVZT4lJBhXzxc09APx7/Pg8tLamsDW+fEWXaaP N/a6X1zI3DQos3euCBVeiCArgMB27RdREqYljqCOz4SH/AJgnYNJW72LOF/4CCQdSTYU IORyA8+L4Kpxxi1/UVnk4OIt0H2ZaxDTMfowszxVERr/XNZIzKLM5lTHZdk1713Fu9Yz FkZ6zLs/uxZZmrKGydvgJpdUGwVKhRv4SuW5QluKBJ9p9LLUQGNJRdsHk++Yn3/hqPpJ DH/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MkVLqrLl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si18303563edj.116.2021.07.23.11.50.22; Fri, 23 Jul 2021 11:50:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MkVLqrLl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229627AbhGWSIA (ORCPT + 99 others); Fri, 23 Jul 2021 14:08:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31702 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbhGWSH7 (ORCPT ); Fri, 23 Jul 2021 14:07:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627066112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TT3QlzruQFM0O9S/g7+HR5WRHatrYiPktX1CpTRxfHI=; b=MkVLqrLloHwsyDjO5cgdF1YaktoR+OAhFpjgZkybTxViOLYA5T7YIb1hfGhEXkjdsZMnjP +CvixTtIaOauh7TjI94jZWDGlUbsleNNxKzKWX66jWhTeJDm8IB6LPu8T7J/sfb9HcmHvS WS7dZExoNgySvOZIEHrrvOawAER4Elo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-D5fHKXg2MlGl5-vM5_cyzQ-1; Fri, 23 Jul 2021 14:48:31 -0400 X-MC-Unique: D5fHKXg2MlGl5-vM5_cyzQ-1 Received: by mail-wr1-f69.google.com with SMTP id s8-20020a5d42480000b02901404c442853so1290938wrr.12 for ; Fri, 23 Jul 2021 11:48:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TT3QlzruQFM0O9S/g7+HR5WRHatrYiPktX1CpTRxfHI=; b=lBqUIjhbUYfdjvSz6DGDS9Pv6FRkGU8EAM2fqVZHrKj9y9eYucG28pu1SAAfh855dQ 9/ppNL8hKb7RdJVcyRBrZceVOsJ/bx4FuoauNJuSaik7LRnACc9TANdRu/OT6TXdKuZe Csx288PNyOHB4vA63WfeXf57OCDZzMXRLF0V5Pd+szG7h86GgwJsWHN+A+UoMVyx0ijr SEQUXtfsF351SSML0qBjmJSMjzCOmA4k9vEVZV39Dt5ndN3z8SpxyF7zTA9eSrbJvUQJ simO0YDfiqm/xMf6LqCD1AD7TxK9zvkqFgdNJRVSqSJE6gbUTp09pnqhY1QMyK6v9DLr oqDQ== X-Gm-Message-State: AOAM532xsDT60QGhQls76dh9ykE3PRyF4El4hQvSjqUNWKHkvDTRbw3G KF5AfniwEYxCVQFQPiJF4T1V8M1ooX6I4ZDxea4tBMCsLmElJVe2sx+Ih/X0hIS+4LOFwROyNiU Zkuq8OxD4ibARDulxdLeL9+gmSxRppVmhfJztfa0d X-Received: by 2002:adf:ec0c:: with SMTP id x12mr6982929wrn.113.1627066110110; Fri, 23 Jul 2021 11:48:30 -0700 (PDT) X-Received: by 2002:adf:ec0c:: with SMTP id x12mr6982917wrn.113.1627066109896; Fri, 23 Jul 2021 11:48:29 -0700 (PDT) MIME-Version: 1.0 References: <20210723091534.1730564-1-arnd@kernel.org> <7ddd0c7c-9bdc-9ea3-c635-f1d141d1e870@infradead.org> In-Reply-To: From: Karol Herbst Date: Fri, 23 Jul 2021 20:48:19 +0200 Message-ID: Subject: Re: [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n To: Arnd Bergmann Cc: Randy Dunlap , Ben Skeggs , David Airlie , Daniel Vetter , Lyude Paul , Arnd Bergmann , nouveau , LKML , dri-devel , Nikola Cornij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 23, 2021 at 8:40 PM Arnd Bergmann wrote: > > On Fri, Jul 23, 2021 at 6:34 PM Karol Herbst wrote: > > On Fri, Jul 23, 2021 at 6:31 PM Randy Dunlap wrote: > > > On 7/23/21 8:15 AM, Karol Herbst wrote: > > > > On Fri, Jul 23, 2021 at 5:10 PM Randy Dunlap wrote: > > > > > > > > what's actually the use case of compiling with > > > > CONFIG_DRM_NOUVEAU_BACKLIGHT=n anyway? > > > > > > Dunno. In this case it was just a randconfig. Still, it needs to be > > > handled in some way - such as the other suggestion in this thread. > > > > > > > sure, I was just curious if there was a specific use case or just > > something random as you mentioned. > > I think this is purely done because of tradition. A long time ago, we had > tiny framebuffer drivers and most PCs did not have backlights, so it > made sense to leave this optional. > > This was probably just always carried over. > > Arnd > okay. I think I will write a patch for nouveau then and send it out soonish