Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp1614023pxv; Fri, 23 Jul 2021 12:46:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVQDcAHK7dqmodi4y7iIkQHWvEZwYT0o4Pcn8XKdj7s7mUCQ2XunDvZH57eK6EyBr8E/dE X-Received: by 2002:a02:7f47:: with SMTP id r68mr5450057jac.127.1627069575555; Fri, 23 Jul 2021 12:46:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627069575; cv=none; d=google.com; s=arc-20160816; b=ks6GulJpcGSn/GvoKIbkklaUO2tTqTNayDn0/2yF+1bkxUpd0+a3MwsrKAVxH0S8LO MXpasSEAXtvuEhsx9yx6ex2md7TEA1Vmc/812OPVQW4zfSGU2koJsq3jgd22CRVXOLRv vXc+bMiFq164BNQ2EH9WuPrQO70y/V8piT1+zeDfnggWlonrFMIaFrAn9xW5ROk4T7jM smnDdHvqeVsg4FEqMVZEiELc/MuEtJ4Jupt5xLQea0KOLs6sgvitEtPpnFTZuuPBhzsC VtYpFt03ZMr6Nvd+MBWy/epsntfZ63RIEE01bDXg5HSFfdBhP2Esq8PgAaDpKXTGvsMD tHPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=QNZENHO+dKLQGyNSvg/QhBqsuG8rka7B9Jc327gNXJ8=; b=wrg+qMvSbXolh2bVQvka4acE36yJ1bxieyEA4RzXtZyQxw+/0m8dbBKBgaT85mSYj6 9RT5qV8XMVgSLqeLrtikwHmAkv6bkyP5slhzDZPAQI18B0rf6T3uUjhPlAsWCOgkeUme s8U66WY8veKy7zs1TOYGDTfe/HeGCOTh5Vvk4hYWpAsx8mQqvgd5wgNDnn3HrNcr60YX Z/EJ0NxtlswoMpm9ld16wZ/QYzgMQjKCxYqouIDNIjng3bKZNwye1f+EaDRYyBBhf2zu q4ODcB4V42vNikVMQucClYX00qBe3jJen+XRU9VdB/04y2FZ1zW8XUfbIbQG7pl+U95c KBhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CSNnsWrO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b16si8665500ior.73.2021.07.23.12.46.04; Fri, 23 Jul 2021 12:46:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CSNnsWrO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229878AbhGWTDX (ORCPT + 99 others); Fri, 23 Jul 2021 15:03:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbhGWTDV (ORCPT ); Fri, 23 Jul 2021 15:03:21 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCBFBC061575 for ; Fri, 23 Jul 2021 12:43:53 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id c7-20020a9d27870000b02904d360fbc71bso3088581otb.10 for ; Fri, 23 Jul 2021 12:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=QNZENHO+dKLQGyNSvg/QhBqsuG8rka7B9Jc327gNXJ8=; b=CSNnsWrOFG1ZAcdGGRrgOLzEMCaNMWwKz0MzVZd4uW2ixO8KgOX7KWYOKeIUp3lzAZ iDrsJU9Qa01k3fjKieGNzsdnbu4RAPYIdcxeQFjm/rXPXMJweZF8NpOmBhxtSOzfwScX 4Vus3o25vEr5CDCVJ9KSKM2OTbTiQPMSKSYT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=QNZENHO+dKLQGyNSvg/QhBqsuG8rka7B9Jc327gNXJ8=; b=GWydOvdaKLGClJRXgSE4urqXgzNtOzBaVYO83e3QWjnMoHzgRbFLAzMNxquFOeFikL NYoeR2riMZwWOOb0jQYDlWpAPyN+9Kbkns8pH/UVFZ129nTWVNjXlnRFWpZZOewvWG4I 1n8n8tBrnGrhd+MbWW8pnwb49dK2FgNUBKNZefqvFUNwVMqMe5GRST2hNli7RjHevkFL 3wnScEhN4x8qFtTwh19B2cAhebrKxV+ln5CJPxDZvKtuKWj5hOQ+adD21phmi0oX9uXD XmVlI+OLzeZvhgG6IBCd7YT6EyJ2wFLYSOIHgOMDVz+KYF0HVJFxsNw3CNYNH3qksiNN 1wNA== X-Gm-Message-State: AOAM533Qiyo/cPPnLQH6P6cuUtbC/PxjDXiHXyCQ5gFRPEXciHzM1FC9 w5x/h8/jPxPfaFkavvvD4jlPm/l22RBFh7k1a71baA== X-Received: by 2002:a9d:1b6e:: with SMTP id l101mr4107722otl.34.1627069433207; Fri, 23 Jul 2021 12:43:53 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 23 Jul 2021 19:43:52 +0000 MIME-Version: 1.0 In-Reply-To: References: From: Stephen Boyd User-Agent: alot/0.9.1 Date: Fri, 23 Jul 2021 19:43:52 +0000 Message-ID: Subject: Re: [PATCH] Input: pm8941-pwrkey - fix comma vs semicolon issue To: Dmitry Torokhov , linux-input@vger.kernel.org Cc: Bjorn Andersson , David Collins , satya priya , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Dmitry Torokhov (2021-07-23 12:39:02) > There is absolutely no reason to use comma operator in this code, 2 > separate statements make much more sense. > > Signed-off-by: Dmitry Torokhov > --- Fixes: 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350 PON_HLOS PMIC peripheral") Reviewed-by: Stephen Boyd