Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Jul 2021 12:52:15 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     linux-input@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        David Collins <collinsd@codeaurora.org>,
        satya priya <skakit@codeaurora.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: pm8941-pwrkey - fix comma vs semicolon issue
Message-ID: <YPsd74LoRtB9tTKK@google.com>
References: <YPsa1qCBn/SAmE5x@google.com>
 <CAE-0n51y=o+8SZTL_==GPXrDa2OP8fhh98Amv+L4M63rLQVGZg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAE-0n51y=o+8SZTL_==GPXrDa2OP8fhh98Amv+L4M63rLQVGZg@mail.gmail.com>
Precedence: bulk

On Fri, Jul 23, 2021 at 07:43:52PM +0000, Stephen Boyd wrote:
> Quoting Dmitry Torokhov (2021-07-23 12:39:02)
> > There is absolutely no reason to use comma operator in this code, 2
> > separate statements make much more sense.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> 
> Fixes: 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350
> PON_HLOS PMIC peripheral")

It actually predates this patch and also not really a fix as the
original code ends up working properly, but looks weird.

> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Thanks!

-- 
Dmitry