Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210715013343.2286699-1-irogers@google.com> <20210715013343.2286699-5-irogers@google.com>
 <YPsKLa0Qe5/as4Jh@kernel.org> <YPsQGZOXqoy7Tfe6@kernel.org> <YPsQ5En9N7xG1Cya@kernel.org>
In-Reply-To: <YPsQ5En9N7xG1Cya@kernel.org>
From:   Ian Rogers <irogers@google.com>
Date:   Fri, 23 Jul 2021 14:03:16 -0700
Message-ID: <CAP-5=fWUr91jLgD-BDYK08v0ELQtypFHDop7QW4uFOPscncCQw@mail.gmail.com>
Subject: Re: [PATCH 4/7] perf doc: Add info pages to all target.
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        eranian@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jul 23, 2021 at 11:56 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Fri, Jul 23, 2021 at 03:53:14PM -0300, Arnaldo Carvalho de Melo escrev=
eu:
> > Em Fri, Jul 23, 2021 at 03:27:57PM -0300, Arnaldo Carvalho de Melo escr=
eveu:
> > > Em Wed, Jul 14, 2021 at 06:33:40PM -0700, Ian Rogers escreveu:
> > > > Enabled to ensure that info pages build.
> > >
> > > How did you test this? I tried installing texinfo, that is where
> > > makeinfo belongs:
> > >
> > > =E2=AC=A2[acme@toolbox perf]$ rpm -qf /usr/bin/makeinfo
> > > texinfo-6.7-10.fc34.x86_64
> > > =E2=AC=A2[acme@toolbox perf]$ rpm -q texinfo
> > > texinfo-6.7-10.fc34.x86_64
> > > =E2=AC=A2[acme@toolbox perf]$
> > >
> > > And then:
> > >
> > > =E2=AC=A2[acme@toolbox perf]$ make -C tools/perf O=3D/tmp/build/perf =
install-doc
> > > make: Entering directory '/var/home/acme/git/perf/tools/perf'
> > >   BUILD:   Doing 'make -j24' parallel build
> > >   INSTALL Documentation-man
> > > make: Leaving directory '/var/home/acme/git/perf/tools/perf'
> > > =E2=AC=A2[acme@toolbox perf]$
> >
> > Also:
>
> We get closer if we do:
>
> =E2=AC=A2[acme@toolbox perf]$ make -C tools/perf/Documentation/ install-i=
nfo
> make: Entering directory '/var/home/acme/git/perf/tools/perf/Documentatio=
n'
>   ASCIIDOC perf.xml
>   DB2TEXI  perf.texi
> /bin/sh: line 2: docbook2x-texi: command not found
> make: *** [Makefile:289: perf.texi] Error 127
> make: Leaving directory '/var/home/acme/git/perf/tools/perf/Documentation=
'
> =E2=AC=A2[acme@toolbox perf]$

Do you need to install docbook2x?

$ dpkg -S /usr/bin/docbook2x-texi
docbook2x: /usr/bin/docbook2x-texi

Thanks,
Ian

> - Arnaldo