Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Jul 2021 17:39:44 -0400
From:   Hamza Mahfooz <someguy@effective-light.com>
Subject: Re: [PATCH v3] HID: logitech-hidpp: battery: provide CAPACITY
 property for newer devices
To:     Filipe =?iso-8859-1?b?TGHtbnM=?= <lains@riseup.net>
Cc:     linux-kernel@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org
Message-Id: <86WPWQ.ODI6WUKUKD0N3@effective-light.com>
In-Reply-To: <e3bdfa16584d7ec832414dcb854ee4d2582543b3.camel@riseup.net>
References: <20210723185720.29314-1-someguy@effective-light.com>
        <e3bdfa16584d7ec832414dcb854ee4d2582543b3.camel@riseup.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 8BIT
Precedence: bulk


On Fri, Jul 23 2021 at 08:42:32 PM +0100, Filipe La?ns 
<lains@riseup.net> wrote:
> That said, I think we should definitely have a comment here nothing 
> that, and
> possible have some bounds checks for the reported voltage value 
> hinting that
> there may be bug.

Hey Filipe,

Do you have any thoughts on what the bounds ought to be?
3500 mV seems like a rather safe lower bound, however the upper bound
seems much more fuzzy.