Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 24 Jul 2021 19:06:11 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <dbe23d2a-cd29-0782-1b7d-bcb5c6683607@collabora.com>
References: <20210710132431.265985-1-linux@fw-web.de> <456f0611-1fc7-75ac-ff45-9afd94190283@collabora.com> <trinity-02bc17fc-b458-4d17-baca-8afe30e4c92c-1626110171249@3c-app-gmx-bs28> <dbe23d2a-cd29-0782-1b7d-bcb5c6683607@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2
Reply-to: frank-w@public-files.de
To:     linux-mediatek@lists.infradead.org,
        Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
        Chun-Kuang Hu <chunkuang.hu@kernel.org>
CC:     David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Frank Wunderlich <linux@fw-web.de>,
        linux-arm-kernel@lists.infradead.org,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Collabora Kernel ML <kernel@collabora.com>
From:   Frank Wunderlich <frank-w@public-files.de>
Message-ID: <6EF00182-1FF4-4061-BCE4-E2AD7275211B@public-files.de>
Precedence: bulk

>On 12=2E07=2E21 19:16, Frank Wunderlich wrote:
>> Hi,
>>=20
>> it turns out that problem is the read+or of the new value
>>=20
>> i reverted my patch and changed
>>=20
>> reg =3D readl_relaxed(mmsys->regs + routes[i]=2Eaddr) | routes[i]=2Eval=
;
>> writel_relaxed(reg, mmsys->regs + routes[i]=2Eaddr);
>>=20
>> to
>>=20
>> writel_relaxed(routes[i]=2Eval, mmsys->regs + routes[i]=2Eaddr);
>>=20
>> and it works too, but maybe it breaks other platforms

A gentle ping=2E Amy further comments which of both ways is the right one =
(restoring old output select function or write only without read+or)?

regards Frank