Date: Wed, 22 Nov 2006 14:32:41 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Nigel Cunningham <ncunningham@linuxmail.org>,
       Andrew Morton <akpm@osdl.org>, Pavel Machek <pavel@ucw.cz>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] swsusp: Fix labels
Message-Id: <20061122143241.6b1a34ac.randy.dunlap@oracle.com>
In-Reply-To: <200611190025.06860.rjw@sisk.pl>
References: <200611182335.27453.rjw@sisk.pl>
	<200611182351.01924.rjw@sisk.pl>
	<1163891174.6787.2.camel@nigel.suspend2.net>
	<200611190025.06860.rjw@sisk.pl>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 994
Lines: 28

On Sun, 19 Nov 2006 00:25:06 +0100 Rafael J. Wysocki wrote:

> On Sunday, 19 November 2006 00:06, Nigel Cunningham wrote:
> > Hi.
> > 
> > On Sat, 2006-11-18 at 23:51 +0100, Rafael J. Wysocki wrote:
> > > Move all labels in the swsusp code to the second column, so that they won't
> > > fool diff -p.
> > 
> > This sounds like working around brokenness in diff -p. Should/could a
> > patch be submitted to the diff maintainer instead?
> 
> No.  This feature of diff is actually documented.
> 
> There was a discussion on LKML about it some time ago and the patch follows
> the conclusion.

There was discussion, and then both Jesper and I tried to
reproduce the problem with diff and could not do so.
Maybe it has already been fixed. (?)

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/